diff options
| author | Loic Blot <loic.blot@unix-experience.fr> | 2021-04-29 09:40:56 +0200 |
|---|---|---|
| committer | Loïc Blot <nerzhul@users.noreply.github.com> | 2021-05-03 19:49:19 +0200 |
| commit | 5a02c376ea5f2e7f1dd0a2bd4f08bf953ed4bfc8 (patch) | |
| tree | d4bd7334bad7f1bf0d01d1dc6acbaccd34132823 /src/client/clientenvironment.cpp | |
| parent | ccdd886e273ec2fa5f8cfe1d1f474914eccb2abf (diff) | |
| download | minetest-5a02c376ea5f2e7f1dd0a2bd4f08bf953ed4bfc8.tar.xz | |
refacto: RenderingEngine::get_scene_manager() is now not callable from singleton
This permits to make evidence that we have some bad object passing on various code parts. I fixed majority of them to reduce the scope of passed objects
Unfortunately, for some edge cases i should have to expose ISceneManager from client, this should be fixed in the future when our POO will be cleaner client side (we have a mix of rendering and processing in majority of the client objects, it works but it's not clean)
Diffstat (limited to 'src/client/clientenvironment.cpp')
| -rw-r--r-- | src/client/clientenvironment.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/client/clientenvironment.cpp b/src/client/clientenvironment.cpp index 9c40484bf..7e3867537 100644 --- a/src/client/clientenvironment.cpp +++ b/src/client/clientenvironment.cpp @@ -352,7 +352,7 @@ u16 ClientEnvironment::addActiveObject(ClientActiveObject *object) if (!m_ao_manager.registerObject(object)) return 0; - object->addToScene(m_texturesource, RenderingEngine::get_scene_manager()); + object->addToScene(m_texturesource, m_client->getSceneManager()); // Update lighting immediately object->updateLight(getDayNightRatio()); |