diff options
| author | Lars Müller <34514239+appgurueu@users.noreply.github.com> | 2022-08-13 16:35:41 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-13 15:35:41 +0100 |
| commit | 0e439b2fa3f0ba4f3352273519c32ebc9c3a680e (patch) | |
| tree | 9cdfd3f0a67659134b6019f8c58ba76edb31cd2b | |
| parent | 3132efcc0181851192672c52d9f7814ccd2464f7 (diff) | |
| download | minetest-0e439b2fa3f0ba4f3352273519c32ebc9c3a680e.tar.xz | |
Check hp_max > 0 for entities (#12667)
| -rw-r--r-- | src/script/common/c_content.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/script/common/c_content.cpp b/src/script/common/c_content.cpp index 166980025..fafb2edc9 100644 --- a/src/script/common/c_content.cpp +++ b/src/script/common/c_content.cpp @@ -196,6 +196,9 @@ void read_object_properties(lua_State *L, int index, int hp_max = 0; if (getintfield(L, -1, "hp_max", hp_max)) { prop->hp_max = (u16)rangelim(hp_max, 0, U16_MAX); + // hp_max = 0 is sometimes used as a hack to keep players dead, only validate for entities + if (prop->hp_max == 0 && sao->getType() != ACTIVEOBJECT_TYPE_PLAYER) + throw LuaError("The hp_max property may not be 0 for entities!"); if (prop->hp_max < sao->getHP()) { PlayerHPChangeReason reason(PlayerHPChangeReason::SET_HP_MAX); |