Fix pagination losing query arguments

Fixes #205

2 files changed, 33 insertions, 16 deletions

diff --git a/app/templates/macros/pagination.html b/app/templates/macros/pagination.html
new file mode 100644
index 0000000..acef4e7
--- /dev/null
+++ b/app/templates/macros/pagination.html
@@ -0,0 +1,29 @@
+{% macro render_pagination(pagination, url_builder) %}
+	<ul class="pagination mt-4">
+		{% set prev_url = url_builder(pagination.prev_num) if pagination.has_prev %}
+		{% set next_url = url_builder(pagination.next_num) if pagination.has_next %}
+
+		<li class="page-item {% if not prev_url %}disabled{% endif %}">
+			<a class="page-link" {% if prev_url %}href="{{ prev_url }}"{% endif %}>&laquo;</a>
+		</li>
+
+		{%- for page in pagination.iter_pages() %}
+			{% if page %}
+				<li class="page-item {% if page == pagination.page %}active{% endif %}">
+					<a class="page-link"
+							href="{{ url_builder(page) }}">
+						{{ page }}
+					</a>
+				</li>
+			{% else %}
+				<li class="page-item disabled">
+					&ellipsis;
+				</li>
+			{% endif %}
+		{%- endfor %}
+
+		<li class="page-item {% if not next_url %}disabled{% endif %}">
+			<a class="page-link" {% if next_url %}href="{{ next_url }}"{% endif %}>&raquo;</a>
+		</li>
+	</div>
+{% endmacro %}
diff --git a/app/templates/packages/list.html b/app/templates/packages/list.html
index 057fe22..8f3a595 100644
--- a/app/templates/packages/list.html
+++ b/app/templates/packages/list.html
@@ -23,22 +23,10 @@
 	{% from "macros/packagegridtile.html" import render_pkggrid %}
 	{{ render_pkggrid(packages) }}
 
-	<ul class="pagination mt-4">
-		<li class="page-item {% if not prev_url %}disabled{% endif %}">
-			<a class="page-link" {% if prev_url %}href="{{ prev_url }}"{% endif %}>&laquo;</a>
-		</li>
-		{% for n in range(1, page_max+1) %}
-			<li class="page-item {% if n == page %}active{% endif %}">
-				<a class="page-link"
-						href="{{ url_for('packages.list_all', type=type, q=query, page=n) }}">
-					{{ n }}
-				</a>
-			</li>
-		{% endfor %}
-		<li class="page-item {% if not next_url %}disabled{% endif %}">
-			<a class="page-link" {% if next_url %}href="{{ next_url }}"{% endif %}>&raquo;</a>
-		</li>
-	</ul>
+
+	{% from "macros/pagination.html" import render_pagination %}
+	{{ render_pagination(pagination, url_builder) }}
+
 
 	{% if topics %}
 		<h2 style="margin-top:2em;">More content from the forums</h2>