aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTobin Ehlis <tobine@google.com>2017-01-04 09:17:01 -0700
committerTobin Ehlis <tobine@google.com>2017-01-04 15:05:18 -0700
commit675424270e816e322459fdef408e813fa7abd2a7 (patch)
tree0d5af7fe145e05a5dfbfe0ec5108dbc2491820e1
parent22bdeadc8cf005bdd470c535d160ade123f01854 (diff)
downloadusermoji-675424270e816e322459fdef408e813fa7abd2a7.tar.xz
layers:Add TODO comments for valid usage updates
Note a few unique error enum duplicates that should have their own unique ids added through spec updates.
-rw-r--r--layers/core_validation.cpp2
-rw-r--r--layers/descriptor_sets.cpp1
2 files changed, 2 insertions, 1 deletions
diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp
index ea1aedad..04a5fdd6 100644
--- a/layers/core_validation.cpp
+++ b/layers/core_validation.cpp
@@ -8892,7 +8892,7 @@ VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, ui
auto image_view_state = getImageViewState(dev_data, image_view);
auto aspects_present = image_view_state->create_info.subresourceRange.aspectMask;
auto extra_aspects = clear_desc->aspectMask & ~aspects_present;
-
+ // TODO: This is a different check than 01125. Need a new valid usage statement for this case, or should kill check.
if (extra_aspects) {
skip_call |= log_msg(
dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT,
diff --git a/layers/descriptor_sets.cpp b/layers/descriptor_sets.cpp
index 902a71cc..6de07cc3 100644
--- a/layers/descriptor_sets.cpp
+++ b/layers/descriptor_sets.cpp
@@ -1221,6 +1221,7 @@ bool cvdescriptorset::DescriptorSet::ValidateWriteUpdate(const debug_report_data
// Verify consecutive bindings match (if needed)
if (!p_layout_->VerifyUpdateConsistency(update->dstBinding, update->dstArrayElement, update->descriptorCount, "write update to",
set_, error_msg)) {
+ // TODO : Should break out "consecutive binding updates" language into valid usage statements
*error_code = VALIDATION_ERROR_00938;
return false;
}