From 675424270e816e322459fdef408e813fa7abd2a7 Mon Sep 17 00:00:00 2001 From: Tobin Ehlis Date: Wed, 4 Jan 2017 09:17:01 -0700 Subject: layers:Add TODO comments for valid usage updates Note a few unique error enum duplicates that should have their own unique ids added through spec updates. --- layers/core_validation.cpp | 2 +- layers/descriptor_sets.cpp | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/layers/core_validation.cpp b/layers/core_validation.cpp index ea1aedad..04a5fdd6 100644 --- a/layers/core_validation.cpp +++ b/layers/core_validation.cpp @@ -8892,7 +8892,7 @@ VKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, ui auto image_view_state = getImageViewState(dev_data, image_view); auto aspects_present = image_view_state->create_info.subresourceRange.aspectMask; auto extra_aspects = clear_desc->aspectMask & ~aspects_present; - + // TODO: This is a different check than 01125. Need a new valid usage statement for this case, or should kill check. if (extra_aspects) { skip_call |= log_msg( dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, diff --git a/layers/descriptor_sets.cpp b/layers/descriptor_sets.cpp index 902a71cc..6de07cc3 100644 --- a/layers/descriptor_sets.cpp +++ b/layers/descriptor_sets.cpp @@ -1221,6 +1221,7 @@ bool cvdescriptorset::DescriptorSet::ValidateWriteUpdate(const debug_report_data // Verify consecutive bindings match (if needed) if (!p_layout_->VerifyUpdateConsistency(update->dstBinding, update->dstArrayElement, update->descriptorCount, "write update to", set_, error_msg)) { + // TODO : Should break out "consecutive binding updates" language into valid usage statements *error_code = VALIDATION_ERROR_00938; return false; } -- cgit v1.2.3