Replace impl Read with Cursor<&[u8]> (#26)

* Start getting rid of Cursor

* try to make the tests pass and fail

* make the tests pass

* remove unused uses

* fix clippy warnings

* fix potential OOM exploits

* fix OOM in az-nbt

* fix nbt benchmark

* fix a test

* start replacing it with Cursor<Vec<u8>>

* wip

* fix all the issues

* fix all tests

* fix nbt benchmark

* fix warnings

1 files changed, 13 insertions, 11 deletions

diff --git a/azalea-nbt/tests/tests.rs b/azalea-nbt/tests/tests.rs
index 41a14d1b..43c31590 100755
--- a/azalea-nbt/tests/tests.rs
+++ b/azalea-nbt/tests/tests.rs
@@ -9,7 +9,9 @@ use std::{
 fn test_decode_hello_world() {
     // read hello_world.nbt
     let mut file = File::open("tests/hello_world.nbt").unwrap();
-    let tag = Tag::read(&mut file).unwrap();
+    let mut buf = vec![];
+    file.read_to_end(&mut buf).unwrap();
+    let tag = Tag::read(&mut Cursor::new(&buf[..])).unwrap();
     assert_eq!(
         tag,
         Tag::Compound(AHashMap::from_iter(vec![(
@@ -28,14 +30,14 @@ fn test_roundtrip_hello_world() {
     let mut original = Vec::new();
     file.read_to_end(&mut original).unwrap();
 
-    let mut original_stream = Cursor::new(original.clone());
+    let mut original_stream = Cursor::new(&original[..]);
     let tag = Tag::read(&mut original_stream).unwrap();
 
     // write hello_world.nbt
-    let mut result = Cursor::new(Vec::new());
+    let mut result = Vec::new();
     tag.write(&mut result).unwrap();
 
-    assert_eq!(result.into_inner(), original);
+    assert_eq!(result, original);
 }
 
 #[test]
@@ -45,13 +47,13 @@ fn test_bigtest() {
     let mut original = Vec::new();
     file.read_to_end(&mut original).unwrap();
 
-    let mut original_stream = Cursor::new(original.clone());
+    let mut original_stream = Cursor::new(original);
     let original_tag = Tag::read_gzip(&mut original_stream).unwrap();
 
     let mut result = Vec::new();
     original_tag.write(&mut result).unwrap();
 
-    let decoded_tag = Tag::read(&mut Cursor::new(result)).unwrap();
+    let decoded_tag = Tag::read(&mut Cursor::new(&result)).unwrap();
 
     assert_eq!(decoded_tag, original_tag);
 }
@@ -83,7 +85,7 @@ fn test_stringtest() {
     let mut original = Vec::new();
     file.read_to_end(&mut original).unwrap();
 
-    let mut original_stream = Cursor::new(original.clone());
+    let mut original_stream = Cursor::new(original);
     let original_tag = Tag::read_gzip(&mut original_stream).unwrap();
 
     assert_eq!(original_tag, correct_tag);
@@ -95,13 +97,13 @@ fn test_complex_player() {
     let mut original = Vec::new();
     file.read_to_end(&mut original).unwrap();
 
-    let mut original_stream = Cursor::new(original.clone());
+    let mut original_stream = Cursor::new(original);
     let original_tag = Tag::read_gzip(&mut original_stream).unwrap();
 
     let mut result = Vec::new();
     original_tag.write(&mut result).unwrap();
 
-    let decoded_tag = Tag::read(&mut Cursor::new(result)).unwrap();
+    let decoded_tag = Tag::read(&mut Cursor::new(&result)).unwrap();
 
     assert_eq!(decoded_tag, original_tag);
 }
@@ -112,13 +114,13 @@ fn test_simple_player() {
     let mut original = Vec::new();
     file.read_to_end(&mut original).unwrap();
 
-    let mut original_stream = Cursor::new(original.clone());
+    let mut original_stream = Cursor::new(original);
     let original_tag = Tag::read_gzip(&mut original_stream).unwrap();
 
     let mut result = Vec::new();
     original_tag.write(&mut result).unwrap();
 
-    let decoded_tag = Tag::read(&mut Cursor::new(result)).unwrap();
+    let decoded_tag = Tag::read(&mut Cursor::new(&result)).unwrap();
 
     assert_eq!(decoded_tag, original_tag);
 }