diff options
| author | Sculas <contact@sculas.xyz> | 2022-10-17 20:18:25 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-17 13:18:25 -0500 |
| commit | d4d4ba054f4da0dcf550524523792ee79268d40d (patch) | |
| tree | 7fcf3e70653caa2a88a99b57691ab5725c27f454 | |
| parent | 96e94aa424bf4468bcd6106ed43dc7990bead2d5 (diff) | |
| download | azalea-drasl-d4d4ba054f4da0dcf550524523792ee79268d40d.tar.xz | |
refactor: remove println statements (#31)
This PR removes all println statements and logs them on trace level instead. Normally, libraries shouldn't print to stdout using println, since there's no control over them.
| -rw-r--r-- | azalea-auth/src/cache.rs | 2 | ||||
| -rw-r--r-- | azalea-auth/src/sessionserver.rs | 1 | ||||
| -rwxr-xr-x | azalea-brigadier/src/command_dispatcher.rs | 1 | ||||
| -rw-r--r-- | azalea-client/src/movement.rs | 5 | ||||
| -rw-r--r-- | azalea-world/src/chunk_storage.rs | 5 |
5 files changed, 7 insertions, 7 deletions
diff --git a/azalea-auth/src/cache.rs b/azalea-auth/src/cache.rs index 8af9e171..e84c60fd 100644 --- a/azalea-auth/src/cache.rs +++ b/azalea-auth/src/cache.rs @@ -71,7 +71,7 @@ async fn get_entire_cache(cache_file: &Path) -> Result<Vec<CachedAccount>, Cache Ok(cache) } async fn set_entire_cache(cache_file: &Path, cache: Vec<CachedAccount>) -> Result<(), CacheError> { - println!("saving cache: {:?}", cache); + log::trace!("saving cache: {:?}", cache); let mut cache_file = File::create(cache_file).await.map_err(CacheError::Write)?; let cache = serde_json::to_string_pretty(&cache).map_err(CacheError::Parse)?; diff --git a/azalea-auth/src/sessionserver.rs b/azalea-auth/src/sessionserver.rs index 31857bc0..fe0b694a 100644 --- a/azalea-auth/src/sessionserver.rs +++ b/azalea-auth/src/sessionserver.rs @@ -51,7 +51,6 @@ pub async fn join( "selectedProfile": undashed_uuid, "serverId": server_hash }); - println!("data: {:?}", data); let res = client .post("https://sessionserver.mojang.com/session/minecraft/join") .json(&data) diff --git a/azalea-brigadier/src/command_dispatcher.rs b/azalea-brigadier/src/command_dispatcher.rs index 6d1f28b1..8c211555 100755 --- a/azalea-brigadier/src/command_dispatcher.rs +++ b/azalea-brigadier/src/command_dispatcher.rs @@ -231,7 +231,6 @@ impl<S> CommandDispatcher<S> { for context in contexts.iter() { let child = &context.child; if let Some(child) = child { - println!("aaaaaaa {:?}", child); forked |= child.forks; if child.has_nodes() { found_command = true; diff --git a/azalea-client/src/movement.rs b/azalea-client/src/movement.rs index fb4a5968..85cf6bdd 100644 --- a/azalea-client/src/movement.rs +++ b/azalea-client/src/movement.rs @@ -144,9 +144,10 @@ impl Client { let mut entity = player .entity_mut(&mut dimension_lock) .ok_or(MovePlayerError::PlayerNotInWorld)?; - println!( + log::trace!( "move entity bounding box: {} {:?}", - entity.id, entity.bounding_box + entity.id, + entity.bounding_box ); entity.move_colliding(&MoverType::Own, movement)?; diff --git a/azalea-world/src/chunk_storage.rs b/azalea-world/src/chunk_storage.rs index 566b3198..daabb214 100644 --- a/azalea-world/src/chunk_storage.rs +++ b/azalea-world/src/chunk_storage.rs @@ -104,7 +104,7 @@ impl ChunkStorage { data: &mut Cursor<&[u8]>, ) -> Result<(), BufReadError> { if !self.in_range(pos) { - println!( + log::trace!( "Ignoring chunk since it's not in the view range: {}, {}", pos.x, pos.z ); @@ -115,7 +115,8 @@ impl ChunkStorage { data, self.height, )?)); - println!("Loaded chunk {:?}", pos); + + log::trace!("Loaded chunk {:?}", pos); self[pos] = Some(chunk); Ok(()) |
