fix random warnings

8 files changed, 6 insertions, 21 deletions

diff --git a/azalea-client/src/connect.rs b/azalea-client/src/connect.rs
index c04126dc..6ed25bff 100644
--- a/azalea-client/src/connect.rs
+++ b/azalea-client/src/connect.rs
@@ -70,13 +70,6 @@ pub async fn join_server(address: &ServerAddress) -> Result<(), String> {
                 GamePacket::ClientboundCustomPayloadPacket(p) => {
                     println!("Got custom payload packet {:?}", p);
                 }
-                // GamePacket::ClientboundKeepAlivePacket(p) => {
-                //     println!("Got keep alive packet {:?}", p.keep_alive_id);
-                // }
-                // GamePacket::ClientboundChatMessagePacket(p) => {
-                //     println!("Got chat message packet {:?}", p.message);
-                // }
-                _ => panic!("unhandled packet"),
             },
             Err(e) => {
                 println!("Error: {:?}", e);
diff --git a/azalea-core/src/game_type.rs b/azalea-core/src/game_type.rs
index b6ff479d..f5b9fb38 100644
--- a/azalea-core/src/game_type.rs
+++ b/azalea-core/src/game_type.rs
@@ -1,5 +1,3 @@
-use azalea_chat;
-
 #[derive(Hash, Clone, Debug)]
 pub enum GameType {
     SURVIVAL,
diff --git a/azalea-protocol/packet-macros/src/lib.rs b/azalea-protocol/packet-macros/src/lib.rs
index ba963111..957515c4 100644
--- a/azalea-protocol/packet-macros/src/lib.rs
+++ b/azalea-protocol/packet-macros/src/lib.rs
@@ -24,7 +24,7 @@ fn as_packet_derive(
             // do a different buf.write_* for each field depending on the type
             // if it's a string, use buf.write_string
             match field_type {
-                syn::Type::Path(syn::TypePath { path, .. }) => {
+                syn::Type::Path(_) => {
                     if f.attrs.iter().any(|attr| attr.path.is_ident("varint")) {
                         quote! {
                             crate::mc_buf::McBufVarintWritable::varint_write_into(&self.#field_name, buf)?;
@@ -52,7 +52,7 @@ fn as_packet_derive(
             // do a different buf.write_* for each field depending on the type
             // if it's a string, use buf.write_string
             match field_type {
-                syn::Type::Path(syn::TypePath { path, .. }) => {
+                syn::Type::Path(_) => {
                         if f.attrs.iter().any(|a| a.path.is_ident("varint")) {
                             quote! {
                                 let #field_name = crate::mc_buf::McBufVarintReadable::varint_read_into(buf).await?;
diff --git a/azalea-protocol/src/mc_buf/write.rs b/azalea-protocol/src/mc_buf/write.rs
index 14dac9d1..6fbe6eab 100644
--- a/azalea-protocol/src/mc_buf/write.rs
+++ b/azalea-protocol/src/mc_buf/write.rs
@@ -265,14 +265,14 @@ impl McBufWritable for GameType {
 // Option<GameType>
 impl McBufWritable for Option<GameType> {
     fn write_into(&self, buf: &mut Vec<u8>) -> Result<(), std::io::Error> {
-        buf.write_byte(GameType::to_optional_id(&self) as u8)
+        buf.write_byte(GameType::to_optional_id(self) as u8)
     }
 }
 
 // Vec<ResourceLocation>
 impl McBufWritable for Vec<ResourceLocation> {
     fn write_into(&self, buf: &mut Vec<u8>) -> Result<(), std::io::Error> {
-        buf.write_list(&self, |buf, resource_location| {
+        buf.write_list(self, |buf, resource_location| {
             buf.write_resource_location(resource_location)
         })
     }
diff --git a/azalea-protocol/src/packets/game/clientbound_custom_payload_packet.rs b/azalea-protocol/src/packets/game/clientbound_custom_payload_packet.rs
index 4ee0ddf0..134a3109 100644
--- a/azalea-protocol/src/packets/game/clientbound_custom_payload_packet.rs
+++ b/azalea-protocol/src/packets/game/clientbound_custom_payload_packet.rs
@@ -1,4 +1,3 @@
-use crate::mc_buf::{Readable, Writable};
 use azalea_core::resource_location::ResourceLocation;
 use packet_macros::GamePacket;
 
diff --git a/azalea-protocol/src/packets/handshake/client_intention_packet.rs b/azalea-protocol/src/packets/handshake/client_intention_packet.rs
index 00d124a4..6216ddc4 100644
--- a/azalea-protocol/src/packets/handshake/client_intention_packet.rs
+++ b/azalea-protocol/src/packets/handshake/client_intention_packet.rs
@@ -1,8 +1,4 @@
-use crate::{
-    mc_buf::{Readable, Writable},
-    packets::ConnectionProtocol,
-};
-use num_traits::FromPrimitive;
+use crate::packets::ConnectionProtocol;
 use packet_macros::HandshakePacket;
 use std::hash::Hash;
 
diff --git a/azalea-protocol/src/packets/login/clientbound_custom_query_packet.rs b/azalea-protocol/src/packets/login/clientbound_custom_query_packet.rs
index 77262c43..3138106e 100644
--- a/azalea-protocol/src/packets/login/clientbound_custom_query_packet.rs
+++ b/azalea-protocol/src/packets/login/clientbound_custom_query_packet.rs
@@ -1,4 +1,3 @@
-use crate::mc_buf::{Readable, Writable};
 use azalea_core::resource_location::ResourceLocation;
 use packet_macros::LoginPacket;
 use std::hash::Hash;
diff --git a/azalea-protocol/src/write.rs b/azalea-protocol/src/write.rs
index 3898e74a..821ed6e8 100644
--- a/azalea-protocol/src/write.rs
+++ b/azalea-protocol/src/write.rs
@@ -17,7 +17,7 @@ fn packet_encoder<P: ProtocolPacket + std::fmt::Debug>(packet: &P) -> Result<Vec
     let mut buf = Vec::new();
     buf.write_varint(packet.id() as i32)
         .map_err(|e| e.to_string())?;
-    packet.write(&mut buf);
+    packet.write(&mut buf).map_err(|e| e.to_string())?;
     if buf.len() > MAXIMUM_UNCOMPRESSED_LENGTH as usize {
         return Err(format!(
             "Packet too big (is {} bytes, should be less than {}): {:?}",