aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUbuntu <github@matdoes.dev>2022-09-19 19:53:16 +0000
committerUbuntu <github@matdoes.dev>2022-09-19 19:53:16 +0000
commit14a6f9d9f89452b56102ffc5dc61125cc2b63aff (patch)
treee73c03bb327422142dc27c3b163f49d44f948d0e
parent4247945df13507fb07a4746263bb702d6fbe04cd (diff)
downloadazalea-drasl-14a6f9d9f89452b56102ffc5dc61125cc2b63aff.tar.xz
replace printlns with log
-rwxr-xr-xCargo.lock1
-rwxr-xr-xazalea-client/Cargo.toml1
-rw-r--r--azalea-client/src/client.rs113
-rwxr-xr-xazalea-protocol/src/lib.rs4
-rw-r--r--azalea-protocol/src/packets/game/clientbound_commands_packet.rs3
-rwxr-xr-xazalea-protocol/src/resolver.rs2
6 files changed, 65 insertions, 59 deletions
diff --git a/Cargo.lock b/Cargo.lock
index f4f45242..1e78a8a1 100755
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -167,6 +167,7 @@ dependencies = [
"azalea-physics",
"azalea-protocol",
"azalea-world",
+ "log",
"thiserror",
"tokio",
"uuid",
diff --git a/azalea-client/Cargo.toml b/azalea-client/Cargo.toml
index e69da668..66e5ca42 100755
--- a/azalea-client/Cargo.toml
+++ b/azalea-client/Cargo.toml
@@ -15,6 +15,7 @@ azalea-crypto = {path = "../azalea-crypto"}
azalea-physics = {path = "../azalea-physics"}
azalea-protocol = {path = "../azalea-protocol"}
azalea-world = {path = "../azalea-world"}
+log = "0.4.17"
thiserror = "^1.0.34"
tokio = {version = "^1.19.2", features = ["sync"]}
uuid = "^1.1.2"
diff --git a/azalea-client/src/client.rs b/azalea-client/src/client.rs
index 5f26ee35..14ebf9e9 100644
--- a/azalea-client/src/client.rs
+++ b/azalea-client/src/client.rs
@@ -28,6 +28,7 @@ use azalea_protocol::{
};
use azalea_world::entity::EntityData;
use azalea_world::Dimension;
+use log::{debug, error, warn};
use std::{
fmt::Debug,
io,
@@ -146,7 +147,7 @@ impl Client {
match packet_result {
Ok(packet) => match packet {
ClientboundLoginPacket::Hello(p) => {
- println!("Got encryption request");
+ debug!("Got encryption request");
let e = azalea_crypto::encrypt(&p.public_key, &p.nonce).unwrap();
// TODO: authenticate with the server here (authenticateServer)
@@ -164,18 +165,18 @@ impl Client {
conn.set_encryption_key(e.secret_key);
}
ClientboundLoginPacket::LoginCompression(p) => {
- println!("Got compression request {:?}", p.compression_threshold);
+ debug!("Got compression request {:?}", p.compression_threshold);
conn.set_compression_threshold(p.compression_threshold);
}
ClientboundLoginPacket::GameProfile(p) => {
- println!("Got profile {:?}", p.game_profile);
+ debug!("Got profile {:?}", p.game_profile);
break (conn.game(), p.game_profile);
}
ClientboundLoginPacket::LoginDisconnect(p) => {
- println!("Got disconnect {:?}", p);
+ debug!("Got disconnect {:?}", p);
}
ClientboundLoginPacket::CustomQuery(p) => {
- println!("Got custom query {:?}", p);
+ debug!("Got custom query {:?}", p);
}
},
Err(e) => {
@@ -215,7 +216,7 @@ impl Client {
Ok(packet) => match Self::handle(&packet, &client, &tx).await {
Ok(_) => {}
Err(e) => {
- println!("Error handling packet: {}", e);
+ error!("Error handling packet: {}", e);
if IGNORE_ERRORS {
continue;
} else {
@@ -225,7 +226,7 @@ impl Client {
},
Err(e) => {
if IGNORE_ERRORS {
- println!("{}", e);
+ warn!("{}", e);
match e {
ReadPacketError::FrameSplitter { .. } => panic!("Error: {:?}", e),
_ => continue,
@@ -245,7 +246,7 @@ impl Client {
) -> Result<(), HandleError> {
match packet {
ClientboundGamePacket::Login(p) => {
- println!("Got login packet {:?}", p);
+ debug!("Got login packet {:?}", p);
{
// // write p into login.txt
@@ -338,41 +339,41 @@ impl Client {
tx.send(Event::Login).unwrap();
}
ClientboundGamePacket::UpdateViewDistance(p) => {
- println!("Got view distance packet {:?}", p);
+ debug!("Got view distance packet {:?}", p);
}
ClientboundGamePacket::CustomPayload(p) => {
- println!("Got custom payload packet {:?}", p);
+ debug!("Got custom payload packet {:?}", p);
}
ClientboundGamePacket::ChangeDifficulty(p) => {
- println!("Got difficulty packet {:?}", p);
+ debug!("Got difficulty packet {:?}", p);
}
ClientboundGamePacket::Commands(_p) => {
- println!("Got declare commands packet");
+ debug!("Got declare commands packet");
}
ClientboundGamePacket::PlayerAbilities(p) => {
- println!("Got player abilities packet {:?}", p);
+ debug!("Got player abilities packet {:?}", p);
}
ClientboundGamePacket::SetCarriedItem(p) => {
- println!("Got set carried item packet {:?}", p);
+ debug!("Got set carried item packet {:?}", p);
}
ClientboundGamePacket::UpdateTags(_p) => {
- println!("Got update tags packet");
+ debug!("Got update tags packet");
}
ClientboundGamePacket::Disconnect(p) => {
- println!("Got disconnect packet {:?}", p);
+ debug!("Got disconnect packet {:?}", p);
}
ClientboundGamePacket::UpdateRecipes(_p) => {
- println!("Got update recipes packet");
+ debug!("Got update recipes packet");
}
ClientboundGamePacket::EntityEvent(_p) => {
- // println!("Got entity event packet {:?}", p);
+ // debug!("Got entity event packet {:?}", p);
}
ClientboundGamePacket::Recipe(_p) => {
- println!("Got recipe packet");
+ debug!("Got recipe packet");
}
ClientboundGamePacket::PlayerPosition(p) => {
// TODO: reply with teleport confirm
- println!("Got player position packet {:?}", p);
+ debug!("Got player position packet {:?}", p);
let (new_pos, y_rot, x_rot) = {
let player_entity_id = {
@@ -463,20 +464,20 @@ impl Client {
.await?;
}
ClientboundGamePacket::PlayerInfo(p) => {
- println!("Got player info packet {:?}", p);
+ debug!("Got player info packet {:?}", p);
}
ClientboundGamePacket::SetChunkCacheCenter(p) => {
- println!("Got chunk cache center packet {:?}", p);
+ debug!("Got chunk cache center packet {:?}", p);
client
.dimension
.lock()?
.update_view_center(&ChunkPos::new(p.x, p.z));
}
ClientboundGamePacket::LevelChunkWithLight(p) => {
- println!("Got chunk with light packet {} {}", p.x, p.z);
+ debug!("Got chunk with light packet {} {}", p.x, p.z);
let pos = ChunkPos::new(p.x, p.z);
// let chunk = Chunk::read_with_world_height(&mut p.chunk_data);
- // println("chunk {:?}")
+ // debug("chunk {:?}")
client
.dimension
.lock()?
@@ -484,47 +485,47 @@ impl Client {
.unwrap();
}
ClientboundGamePacket::LightUpdate(p) => {
- println!("Got light update packet {:?}", p);
+ debug!("Got light update packet {:?}", p);
}
ClientboundGamePacket::AddEntity(p) => {
- println!("Got add entity packet {:?}", p);
+ debug!("Got add entity packet {:?}", p);
let entity = EntityData::from(p);
client.dimension.lock()?.add_entity(p.id, entity);
}
ClientboundGamePacket::SetEntityData(_p) => {
- // println!("Got set entity data packet {:?}", p);
+ // debug!("Got set entity data packet {:?}", p);
}
ClientboundGamePacket::UpdateAttributes(_p) => {
- // println!("Got update attributes packet {:?}", p);
+ // debug!("Got update attributes packet {:?}", p);
}
ClientboundGamePacket::EntityVelocity(_p) => {
- // println!("Got entity velocity packet {:?}", p);
+ // debug!("Got entity velocity packet {:?}", p);
}
ClientboundGamePacket::SetEntityLink(p) => {
- println!("Got set entity link packet {:?}", p);
+ debug!("Got set entity link packet {:?}", p);
}
ClientboundGamePacket::AddPlayer(p) => {
- println!("Got add player packet {:?}", p);
+ debug!("Got add player packet {:?}", p);
let entity = EntityData::from(p);
client.dimension.lock()?.add_entity(p.id, entity);
}
ClientboundGamePacket::InitializeBorder(p) => {
- println!("Got initialize border packet {:?}", p);
+ debug!("Got initialize border packet {:?}", p);
}
ClientboundGamePacket::SetTime(p) => {
- println!("Got set time packet {:?}", p);
+ debug!("Got set time packet {:?}", p);
}
ClientboundGamePacket::SetDefaultSpawnPosition(p) => {
- println!("Got set default spawn position packet {:?}", p);
+ debug!("Got set default spawn position packet {:?}", p);
}
ClientboundGamePacket::ContainerSetContent(p) => {
- println!("Got container set content packet {:?}", p);
+ debug!("Got container set content packet {:?}", p);
}
ClientboundGamePacket::SetHealth(p) => {
- println!("Got set health packet {:?}", p);
+ debug!("Got set health packet {:?}", p);
}
ClientboundGamePacket::SetExperience(p) => {
- println!("Got set experience packet {:?}", p);
+ debug!("Got set experience packet {:?}", p);
}
ClientboundGamePacket::TeleportEntity(p) => {
let mut dimension_lock = client.dimension.lock()?;
@@ -541,10 +542,10 @@ impl Client {
.map_err(|e| HandleError::Other(e.into()))?;
}
ClientboundGamePacket::UpdateAdvancements(p) => {
- println!("Got update advancements packet {:?}", p);
+ debug!("Got update advancements packet {:?}", p);
}
ClientboundGamePacket::RotateHead(_p) => {
- // println!("Got rotate head packet {:?}", p);
+ // debug!("Got rotate head packet {:?}", p);
}
ClientboundGamePacket::MoveEntityPos(p) => {
let mut dimension_lock = client.dimension.lock()?;
@@ -561,10 +562,10 @@ impl Client {
.map_err(|e| HandleError::Other(e.into()))?;
}
ClientboundGamePacket::MoveEntityRot(_p) => {
- // println!("Got move entity rot packet {:?}", p);
+ // debug!("Got move entity rot packet {:?}", p);
}
ClientboundGamePacket::KeepAlive(p) => {
- println!("Got keep alive packet {:?}", p);
+ debug!("Got keep alive packet {:?}", p);
client
.conn
.lock()
@@ -573,58 +574,58 @@ impl Client {
.await?;
}
ClientboundGamePacket::RemoveEntities(p) => {
- println!("Got remove entities packet {:?}", p);
+ debug!("Got remove entities packet {:?}", p);
}
ClientboundGamePacket::PlayerChat(p) => {
- // println!("Got player chat packet {:?}", p);
+ // debug!("Got player chat packet {:?}", p);
tx.send(Event::Chat(ChatPacket::Player(Box::new(p.clone()))))
.unwrap();
}
ClientboundGamePacket::SystemChat(p) => {
- println!("Got system chat packet {:?}", p);
+ debug!("Got system chat packet {:?}", p);
tx.send(Event::Chat(ChatPacket::System(p.clone()))).unwrap();
}
ClientboundGamePacket::Sound(p) => {
- println!("Got sound packet {:?}", p);
+ debug!("Got sound packet {:?}", p);
}
ClientboundGamePacket::LevelEvent(p) => {
- println!("Got level event packet {:?}", p);
+ debug!("Got level event packet {:?}", p);
}
ClientboundGamePacket::BlockUpdate(p) => {
- println!("Got block update packet {:?}", p);
+ debug!("Got block update packet {:?}", p);
// TODO: update world
let mut dimension = client.dimension.lock()?;
// dimension.get_block_state(pos)
if let Ok(block_state) = BlockState::try_from(p.block_state) {
dimension.set_block_state(&p.pos, block_state);
} else {
- eprintln!(
+ warn!(
"Non-existent block state for block update packet {:?}",
p.block_state
);
}
}
ClientboundGamePacket::Animate(p) => {
- println!("Got animate packet {:?}", p);
+ debug!("Got animate packet {:?}", p);
}
ClientboundGamePacket::SectionBlocksUpdate(p) => {
- println!("Got section blocks update packet {:?}", p);
+ debug!("Got section blocks update packet {:?}", p);
// TODO: update world
}
ClientboundGamePacket::GameEvent(p) => {
- println!("Got game event packet {:?}", p);
+ debug!("Got game event packet {:?}", p);
}
ClientboundGamePacket::LevelParticles(p) => {
- println!("Got level particles packet {:?}", p);
+ debug!("Got level particles packet {:?}", p);
}
ClientboundGamePacket::ServerData(p) => {
- println!("Got server data packet {:?}", p);
+ debug!("Got server data packet {:?}", p);
}
ClientboundGamePacket::SetEquipment(p) => {
- println!("Got set equipment packet {:?}", p);
+ debug!("Got set equipment packet {:?}", p);
}
ClientboundGamePacket::UpdateMobEffect(p) => {
- println!("Got update mob effect packet {:?}", p);
+ debug!("Got update mob effect packet {:?}", p);
}
ClientboundGamePacket::AddExperienceOrb(_) => {}
ClientboundGamePacket::AwardStats(_) => {}
@@ -722,7 +723,7 @@ impl Client {
// TODO: if we're a passenger, send the required packets
if let Err(e) = client.send_position().await {
- println!("Error sending position: {:?}", e);
+ warn!("Error sending position: {:?}", e);
}
client.ai_step();
diff --git a/azalea-protocol/src/lib.rs b/azalea-protocol/src/lib.rs
index 1f864d45..9fff59f8 100755
--- a/azalea-protocol/src/lib.rs
+++ b/azalea-protocol/src/lib.rs
@@ -43,8 +43,10 @@ impl<'a> TryFrom<&'a str> for ServerAddress {
#[cfg(feature = "connecting")]
pub async fn connect(address: ServerAddress) -> Result<(), Box<dyn std::error::Error>> {
+ use log::debug;
+
let resolved_address = resolver::resolve_address(&address).await;
- println!("Resolved address: {:?}", resolved_address);
+ debug!("Resolved address: {:?}", resolved_address);
Ok(())
}
diff --git a/azalea-protocol/src/packets/game/clientbound_commands_packet.rs b/azalea-protocol/src/packets/game/clientbound_commands_packet.rs
index c05f710a..e18cf52b 100644
--- a/azalea-protocol/src/packets/game/clientbound_commands_packet.rs
+++ b/azalea-protocol/src/packets/game/clientbound_commands_packet.rs
@@ -4,6 +4,7 @@ use azalea_buf::McBufVarReadable;
use azalea_buf::{McBufReadable, McBufWritable};
use azalea_core::ResourceLocation;
use azalea_protocol_macros::ClientboundGamePacket;
+use log::warn;
use std::io::{Read, Write};
#[derive(Clone, Debug, McBuf, ClientboundGamePacket)]
@@ -205,7 +206,7 @@ impl McBufReadable for BrigadierNodeStub {
fn read_from(buf: &mut impl Read) -> Result<Self, BufReadError> {
let flags = u8::read_from(buf)?;
if flags > 31 {
- eprintln!(
+ warn!(
"Warning: The flags from a Brigadier node are over 31 ({flags}; {flags:#b}). This is probably a bug.",
);
}
diff --git a/azalea-protocol/src/resolver.rs b/azalea-protocol/src/resolver.rs
index e21362a5..eb081c3f 100755
--- a/azalea-protocol/src/resolver.rs
+++ b/azalea-protocol/src/resolver.rs
@@ -47,7 +47,7 @@ pub async fn resolve_address(address: &ServerAddress) -> Result<ServerIpAddress,
port: redirect_srv.port(),
};
- // println!("redirecting to {:?}", redirect_address);
+ // debug!("redirecting to {:?}", redirect_address);
return resolve_address(&redirect_address).await;
}