From c323bfc6a0016076e3a27a639da23f6c176c68fa Mon Sep 17 00:00:00 2001
From: Dominique Martinet <asmadeus@codewreck.org>
Date: Sat, 12 Aug 2017 00:02:33 +0200
Subject: GLES2: detach and delete shaders after LinkProgram

Also make sure program linked correctly!
---
 render/gles2/renderer.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

(limited to 'render/gles2')

diff --git a/render/gles2/renderer.c b/render/gles2/renderer.c
index 237dc67b..c1bf4815 100644
--- a/render/gles2/renderer.c
+++ b/render/gles2/renderer.c
@@ -30,7 +30,7 @@ static bool compile_shader(GLuint type, const GLchar *src, GLuint *shader) {
 		GL_CALL(glGetShaderInfoLog(*shader, loglen, &loglen, msg));
 		wlr_log(L_ERROR, "Shader compilation failed");
 		wlr_log(L_ERROR, "%s", msg);
-		exit(1);
+		glDeleteShader(*shader);
 		return false;
 	}
 	return true;
@@ -43,13 +43,32 @@ static bool compile_program(const GLchar *vert_src,
 		return false;
 	}
 	if (!compile_shader(GL_FRAGMENT_SHADER, frag_src, &fragment)) {
-		glDeleteProgram(vertex);
+		glDeleteShader(vertex);
 		return false;
 	}
 	*program = GL_CALL(glCreateProgram());
 	GL_CALL(glAttachShader(*program, vertex));
 	GL_CALL(glAttachShader(*program, fragment));
 	GL_CALL(glLinkProgram(*program));
+	GLint success;
+	GL_CALL(glGetProgramiv(*program, GL_LINK_STATUS, &success));
+	if (success == GL_FALSE) {
+		GLint loglen;
+		GL_CALL(glGetProgramiv(*program, GL_INFO_LOG_LENGTH, &loglen));
+		GLchar msg[loglen];
+		GL_CALL(glGetProgramInfoLog(*program, loglen, &loglen, msg));
+		wlr_log(L_ERROR, "Program link failed");
+		wlr_log(L_ERROR, "%s", msg);
+		glDeleteProgram(*program);
+		glDeleteShader(vertex);
+		glDeleteShader(fragment);
+		return false;
+	}
+	glDetachShader(*program, vertex);
+	glDetachShader(*program, fragment);
+	glDeleteShader(vertex);
+	glDeleteShader(fragment);
+
 	return true;
 }
 
-- 
cgit v1.2.3