From a2bbf2c1f70ef374ff4a2506e65379c819b72414 Mon Sep 17 00:00:00 2001 From: Scott Anderson Date: Wed, 22 Aug 2018 21:03:38 +1200 Subject: Make style more consistent --- protocol/meson.build | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'protocol/meson.build') diff --git a/protocol/meson.build b/protocol/meson.build index 73a3156a..58126561 100644 --- a/protocol/meson.build +++ b/protocol/meson.build @@ -76,8 +76,11 @@ foreach p : client_protocols wl_protos_headers += wayland_scanner_client.process(xml) endforeach -lib_wl_protos = static_library('wl_protos', wl_protos_src + wl_protos_headers, - dependencies: [wayland_client]) # for the include directory +lib_wl_protos = static_library( + 'wl_protos', + wl_protos_src + wl_protos_headers, + dependencies: wayland_client.partial_dependency(includes: true), +) wlr_protos = declare_dependency( link_with: lib_wl_protos, -- cgit v1.2.3 From b1ed61b6493e2a5882aedf9d6732d34b390a8d26 Mon Sep 17 00:00:00 2001 From: Scott Anderson Date: Wed, 22 Aug 2018 17:29:43 +1200 Subject: Use pkg-config to find wayland-scanner --- protocol/meson.build | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'protocol/meson.build') diff --git a/protocol/meson.build b/protocol/meson.build index 58126561..17318e1c 100644 --- a/protocol/meson.build +++ b/protocol/meson.build @@ -1,6 +1,14 @@ wl_protocol_dir = wayland_protos.get_pkgconfig_variable('pkgdatadir') -wayland_scanner = find_program('wayland-scanner') +wayland_scanner_dep = dependency('wayland-scanner', required: false, native: true) +if wayland_scanner_dep.found() + wayland_scanner = find_program( + wayland_scanner_dep.get_pkgconfig_variable('wayland_scanner'), + native: true, + ) +else + wayland_scanner = find_program('wayland-scanner', native: true) +endif wayland_scanner_server = generator( wayland_scanner, @@ -8,17 +16,10 @@ wayland_scanner_server = generator( arguments: ['server-header', '@INPUT@', '@OUTPUT@'], ) -# should check wayland_scanner's version, but it is hard to get -if wayland_server.version().version_compare('>=1.14.91') - code_type = 'private-code' -else - code_type = 'code' -endif - wayland_scanner_code = generator( wayland_scanner, output: '@BASENAME@-protocol.c', - arguments: [code_type, '@INPUT@', '@OUTPUT@'], + arguments: ['private-code', '@INPUT@', '@OUTPUT@'], ) wayland_scanner_client = generator( -- cgit v1.2.3 From 39ac21401fddd36474df0191603c0616d332e6da Mon Sep 17 00:00:00 2001 From: Scott Anderson Date: Thu, 23 Aug 2018 14:13:00 +1200 Subject: Replace generator with custom_target This stops the protocol header constantly being regenerated for every target using them. --- protocol/meson.build | 39 ++++++++++++++++++--------------------- 1 file changed, 18 insertions(+), 21 deletions(-) (limited to 'protocol/meson.build') diff --git a/protocol/meson.build b/protocol/meson.build index 17318e1c..2d2a73ed 100644 --- a/protocol/meson.build +++ b/protocol/meson.build @@ -10,24 +10,6 @@ else wayland_scanner = find_program('wayland-scanner', native: true) endif -wayland_scanner_server = generator( - wayland_scanner, - output: '@BASENAME@-protocol.h', - arguments: ['server-header', '@INPUT@', '@OUTPUT@'], -) - -wayland_scanner_code = generator( - wayland_scanner, - output: '@BASENAME@-protocol.c', - arguments: ['private-code', '@INPUT@', '@OUTPUT@'], -) - -wayland_scanner_client = generator( - wayland_scanner, - output: '@BASENAME@-client-protocol.h', - arguments: ['client-header', '@INPUT@', '@OUTPUT@'], -) - protocols = [ [wl_protocol_dir, 'stable/xdg-shell/xdg-shell.xml'], [wl_protocol_dir, 'unstable/idle-inhibit/idle-inhibit-unstable-v1.xml'], @@ -68,13 +50,28 @@ wl_protos_headers = [] foreach p : protocols xml = join_paths(p) - wl_protos_src += wayland_scanner_code.process(xml) - wl_protos_headers += wayland_scanner_server.process(xml) + wl_protos_src += custom_target( + xml.underscorify() + '_server_c', + input: xml, + output: '@BASENAME@-protocol.c', + command: [wayland_scanner, 'private-code', '@INPUT@', '@OUTPUT@'], + ) + wl_protos_headers += custom_target( + xml.underscorify() + '_server_h', + input: xml, + output: '@BASENAME@-protocol.h', + command: [wayland_scanner, 'server-header', '@INPUT@', '@OUTPUT@'], + ) endforeach foreach p : client_protocols xml = join_paths(p) - wl_protos_headers += wayland_scanner_client.process(xml) + wl_protos_headers += custom_target( + xml.underscorify() + '_client_h', + input: xml, + output: '@BASENAME@-client-protocol.h', + command: [wayland_scanner, 'client-header', '@INPUT@', '@OUTPUT@'], + ) endforeach lib_wl_protos = static_library( -- cgit v1.2.3