From dec2565f2b6b0a723d08f025967ac8ff1b7ee756 Mon Sep 17 00:00:00 2001 From: Kirill Primak Date: Mon, 11 Apr 2022 21:33:15 +0300 Subject: xdg-toplevel: don't schedule configures on state requests --- include/wlr/types/wlr_xdg_shell.h | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'include') diff --git a/include/wlr/types/wlr_xdg_shell.h b/include/wlr/types/wlr_xdg_shell.h index 48bfbb97..95c6ee6c 100644 --- a/include/wlr/types/wlr_xdg_shell.h +++ b/include/wlr/types/wlr_xdg_shell.h @@ -147,8 +147,16 @@ struct wlr_xdg_toplevel { char *app_id; struct { + // Note: as per xdg-shell protocol, the compositor has to + // handle state requests by sending a configure event, + // even if it didn't actually change the state. Therefore, + // every compositor implementing xdg-shell support *must* + // listen to these signals and schedule a configure event + // immediately or at some time in the future; not doing so + // is a protocol violation. struct wl_signal request_maximize; struct wl_signal request_fullscreen; + struct wl_signal request_minimize; struct wl_signal request_move; struct wl_signal request_resize; -- cgit v1.2.3