From 9201431c291ccd26d0958e1a8ab9cb9c84763677 Mon Sep 17 00:00:00 2001
From: Simon Ser <contact@emersion.fr>
Date: Mon, 4 Dec 2023 22:43:27 +0100
Subject: xdg-shell: use wlr_surface_synced for toplevel

---
 include/types/wlr_xdg_shell.h      |  1 +
 include/wlr/types/wlr_xdg_shell.h  |  4 ++++
 types/xdg_shell/wlr_xdg_surface.c  | 13 +++++++++++++
 types/xdg_shell/wlr_xdg_toplevel.c | 30 +++++++++++++++++++++++-------
 4 files changed, 41 insertions(+), 7 deletions(-)

diff --git a/include/types/wlr_xdg_shell.h b/include/types/wlr_xdg_shell.h
index 34dec2ad..1ae142fd 100644
--- a/include/types/wlr_xdg_shell.h
+++ b/include/types/wlr_xdg_shell.h
@@ -30,6 +30,7 @@ void create_xdg_toplevel(struct wlr_xdg_surface *surface,
 	uint32_t id);
 void reset_xdg_toplevel(struct wlr_xdg_toplevel *toplevel);
 void destroy_xdg_toplevel(struct wlr_xdg_toplevel *toplevel);
+void handle_xdg_toplevel_client_commit(struct wlr_xdg_toplevel *toplevel);
 void handle_xdg_toplevel_committed(struct wlr_xdg_toplevel *toplevel);
 struct wlr_xdg_toplevel_configure *send_xdg_toplevel_configure(
 	struct wlr_xdg_toplevel *toplevel);
diff --git a/include/wlr/types/wlr_xdg_shell.h b/include/wlr/types/wlr_xdg_shell.h
index fbc771a7..168d76d9 100644
--- a/include/wlr/types/wlr_xdg_shell.h
+++ b/include/wlr/types/wlr_xdg_shell.h
@@ -208,6 +208,10 @@ struct wlr_xdg_toplevel {
 		struct wl_signal set_title;
 		struct wl_signal set_app_id;
 	} events;
+
+	// private state
+
+	struct wlr_surface_synced synced;
 };
 
 struct wlr_xdg_surface_configure {
diff --git a/types/xdg_shell/wlr_xdg_surface.c b/types/xdg_shell/wlr_xdg_surface.c
index 7dd39708..9d46208e 100644
--- a/types/xdg_shell/wlr_xdg_surface.c
+++ b/types/xdg_shell/wlr_xdg_surface.c
@@ -273,6 +273,19 @@ static void xdg_surface_role_client_commit(struct wlr_surface *wlr_surface) {
 			"xdg_surface must have a role object");
 		return;
 	}
+
+	switch (surface->role) {
+	case WLR_XDG_SURFACE_ROLE_NONE:
+		assert(0 && "not reached");
+		return;
+	case WLR_XDG_SURFACE_ROLE_TOPLEVEL:
+		if (surface->toplevel != NULL) {
+			handle_xdg_toplevel_client_commit(surface->toplevel);
+		}
+		break;
+	case WLR_XDG_SURFACE_ROLE_POPUP:
+		break;
+	}
 }
 
 static void xdg_surface_role_commit(struct wlr_surface *wlr_surface) {
diff --git a/types/xdg_shell/wlr_xdg_toplevel.c b/types/xdg_shell/wlr_xdg_toplevel.c
index 3fe49c5a..314611f0 100644
--- a/types/xdg_shell/wlr_xdg_toplevel.c
+++ b/types/xdg_shell/wlr_xdg_toplevel.c
@@ -116,7 +116,7 @@ struct wlr_xdg_toplevel_configure *send_xdg_toplevel_configure(
 	return configure;
 }
 
-void handle_xdg_toplevel_committed(struct wlr_xdg_toplevel *toplevel) {
+void handle_xdg_toplevel_client_commit(struct wlr_xdg_toplevel *toplevel) {
 	struct wlr_xdg_toplevel_state *pending = &toplevel->pending;
 
 	// 1) Negative values are prohibited
@@ -130,9 +130,9 @@ void handle_xdg_toplevel_committed(struct wlr_xdg_toplevel *toplevel) {
 			"client provided an invalid min or max size");
 		return;
 	}
+}
 
-	toplevel->current = toplevel->pending;
-
+void handle_xdg_toplevel_committed(struct wlr_xdg_toplevel *toplevel) {
 	if (toplevel->base->initial_commit) {
 		// On the initial commit, send a configure request to tell the client it
 		// is added
@@ -462,6 +462,10 @@ static const struct xdg_toplevel_interface xdg_toplevel_implementation = {
 	.set_minimized = xdg_toplevel_handle_set_minimized,
 };
 
+static const struct wlr_surface_synced_impl surface_synced_impl = {
+	.state_size = sizeof(struct wlr_xdg_toplevel_state),
+};
+
 void create_xdg_toplevel(struct wlr_xdg_surface *surface,
 		uint32_t id) {
 	if (!set_xdg_surface_role(surface, WLR_XDG_SURFACE_ROLE_TOPLEVEL)) {
@@ -487,14 +491,16 @@ void create_xdg_toplevel(struct wlr_xdg_surface *surface,
 	wl_signal_init(&surface->toplevel->events.set_title);
 	wl_signal_init(&surface->toplevel->events.set_app_id);
 
+	if (!wlr_surface_synced_init(&surface->toplevel->synced, surface->surface,
+			&surface_synced_impl, &surface->toplevel->pending, &surface->toplevel->current)) {
+		goto error_toplevel;
+	}
+
 	surface->toplevel->resource = wl_resource_create(
 		surface->client->client, &xdg_toplevel_interface,
 		wl_resource_get_version(surface->resource), id);
 	if (surface->toplevel->resource == NULL) {
-		free(surface->toplevel);
-		surface->toplevel = NULL;
-		wl_resource_post_no_memory(surface->resource);
-		return;
+		goto error_synced;
 	}
 	wl_resource_set_implementation(surface->toplevel->resource,
 		&xdg_toplevel_implementation, surface->toplevel, NULL);
@@ -502,6 +508,15 @@ void create_xdg_toplevel(struct wlr_xdg_surface *surface,
 	set_xdg_surface_role_object(surface, surface->toplevel->resource);
 
 	wl_signal_emit_mutable(&surface->client->shell->events.new_toplevel, surface->toplevel);
+
+	return;
+
+error_synced:
+	wlr_surface_synced_finish(&surface->toplevel->synced);
+error_toplevel:
+	free(surface->toplevel);
+	surface->toplevel = NULL;
+	wl_resource_post_no_memory(surface->resource);
 }
 
 void reset_xdg_toplevel(struct wlr_xdg_toplevel *toplevel) {
@@ -529,6 +544,7 @@ void destroy_xdg_toplevel(struct wlr_xdg_toplevel *toplevel) {
 
 	wl_signal_emit_mutable(&toplevel->events.destroy, NULL);
 
+	wlr_surface_synced_finish(&toplevel->synced);
 	toplevel->base->toplevel = NULL;
 	wl_resource_set_user_data(toplevel->resource, NULL);
 	free(toplevel);
-- 
cgit v1.2.3