aboutsummaryrefslogtreecommitdiff
path: root/xwayland/selection/incoming.c
diff options
context:
space:
mode:
authorTudor Brindus <me@tbrindus.ca>2021-01-30 14:58:27 -0500
committerSimon Ser <contact@emersion.fr>2021-01-31 19:17:04 +0100
commitb3d782f81877088da496006892f8522299e40ccb (patch)
tree43f605965f0f64e0882583e7bd2897e1135879db /xwayland/selection/incoming.c
parentaa86a022fa00edd0723ff48a6765ee7fbddefadc (diff)
xwayland/selection: introduce `xwm_selection_transfer_init`
Currently, all this does is initialize `wl_client_fd` to -1, so that comparisons with 0 are meaningful.
Diffstat (limited to 'xwayland/selection/incoming.c')
-rw-r--r--xwayland/selection/incoming.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/xwayland/selection/incoming.c b/xwayland/selection/incoming.c
index e41d1287..183d5f88 100644
--- a/xwayland/selection/incoming.c
+++ b/xwayland/selection/incoming.c
@@ -155,7 +155,7 @@ static void source_send(struct wlr_xwm_selection *selection,
// lose track of the current `transfer->wl_client_fd` and use-after-free
// during cleanup. This doesn't happen often, but bail now to avoid a
// compositor crash later.
- if (transfer->wl_client_fd > 0) {
+ if (transfer->wl_client_fd >= 0) {
wlr_log(WLR_ERROR, "source_send fd %d, but %d already in progress", fd,
transfer->wl_client_fd);
if (transfer->wl_client_fd != fd) {
@@ -404,7 +404,7 @@ void xwm_handle_selection_notify(struct wlr_xwm *xwm,
wlr_log(WLR_DEBUG, "denying write access to clipboard: "
"no xwayland surface focused");
// Would leak this transfer otherwise. Should never happen.
- assert(selection->incoming.wl_client_fd <= 0);
+ assert(selection->incoming.wl_client_fd < 0);
return;
}