rootston: fix leak in handle_layer_shell_surface

Found through static analysis

1 files changed, 6 insertions, 6 deletions

diff --git a/rootston/layer_shell.c b/rootston/layer_shell.c
index db0aeb59..2adf11a5 100644
--- a/rootston/layer_shell.c
+++ b/rootston/layer_shell.c
@@ -381,12 +381,6 @@ void handle_layer_shell_surface(struct wl_listener *listener, void *data) {
 		layer_surface->client_pending.margin.bottom,
 		layer_surface->client_pending.margin.left);
 
-	struct roots_layer_surface *roots_surface =
-		calloc(1, sizeof(struct roots_layer_surface));
-	if (!roots_surface) {
-		return;
-	}
-
 	if (!layer_surface->output) {
 		struct roots_input *input = desktop->server->input;
 		struct roots_seat *seat = input_last_active_seat(input);
@@ -409,6 +403,12 @@ void handle_layer_shell_surface(struct wl_listener *listener, void *data) {
 		}
 	}
 
+	struct roots_layer_surface *roots_surface =
+		calloc(1, sizeof(struct roots_layer_surface));
+	if (!roots_surface) {
+		return;
+	}
+
 	roots_surface->surface_commit.notify = handle_surface_commit;
 	wl_signal_add(&layer_surface->surface->events.commit,
 		&roots_surface->surface_commit);