aboutsummaryrefslogtreecommitdiff
path: root/render
diff options
context:
space:
mode:
authorSimon Ser <contact@emersion.fr>2022-10-17 12:29:38 +0200
committerSimon Zeni <simon@bl4ckb0ne.ca>2022-10-17 15:14:02 +0000
commit98a83ce14c96f4727791e9a63fd606fdcaa008fc (patch)
tree1bb6ad766e333d9885088bbdf87d1f71c3bd0668 /render
parentca432ea539614a1e321824c90d81f663f88298ef (diff)
backend/drm: fix EINVAL atomic commits after VT switch
The drm_connector_commit_state() call in handle_session_active() was not resulting in any atomic commit, because it didn't match any of the if branches: active = true, no new buffer was committed, and adaptive sync/gamma LUT were unchanged. Thus the commit was a no-op. Later on, when the compositor performs regular page-flips, the kernel would return EINVAL indicating that a modeset was needed. Rework the logic to use a non-blocking page-flip commit if a buffer was committed, and use a blocking commit if the connector is on or is being disabled. The only case where we should skip the atomic commit is when disabling (active = false) an already-disabled connector (conn->crtc == NULL). Note, 6936e163b514 ("backend/drm: short-circuit no-op commits") has introduced early returns for other situations where we don't need to perform an atomic commit (e.g. updating scale or transform of an output). Fixes: f216e979836a ("backend/drm: drop drm_connector_set_mode()") Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3432
Diffstat (limited to 'render')
0 files changed, 0 insertions, 0 deletions