diff options
| author | Simon Ser <contact@emersion.fr> | 2022-11-15 11:56:45 +0100 |
|---|---|---|
| committer | Kirill Primak <vyivel@eclair.cafe> | 2022-11-15 13:41:09 +0000 |
| commit | 258bf9be1e44d8a2fb953d727ff4ffcf9ebd6503 (patch) | |
| tree | 9bd6ed2293425edd82bb71ca91a2fdeed0b7f51b /include | |
| parent | a40ba16a6414f72ae0224164bb08cd8479dc52ee (diff) | |
compositor: drop wlr_surface.{sx,sy}
The concept of a persistent accumulated surface offset is wrong
from a protocol point-of-view. wl_surface.offset is tied to a
commit, its interpretation depends on the surface role.
For example, with the following sequence:
wl_surface@1.offset(1, 1)
wl_surface@1.commit()
wl_pointer@2.set_cursor(wl_surface@1, 42, 42)
The final cursor hotspot is (42, 42): the commit which happened
before the set_cursor request has no impact on the hotspot
computation.
The wlr_output_cursor logic already uses wlr_surface.current.{dx,dy}.
wlr_scene's drag icon doesn't, update it accordingly.
Diffstat (limited to 'include')
| -rw-r--r-- | include/wlr/types/wlr_compositor.h | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/include/wlr/types/wlr_compositor.h b/include/wlr/types/wlr_compositor.h index f3da622b..194c4e37 100644 --- a/include/wlr/types/wlr_compositor.h +++ b/include/wlr/types/wlr_compositor.h @@ -99,10 +99,6 @@ struct wlr_surface { */ struct wlr_client_buffer *buffer; /** - * The buffer position, in surface-local units. - */ - int sx, sy; - /** * The last commit's buffer damage, in buffer-local coordinates. This * contains both the damage accumulated by the client via * `wlr_surface_state.surface_damage` and `wlr_surface_state.buffer_damage`. |