aboutsummaryrefslogtreecommitdiff
path: root/include/render
diff options
context:
space:
mode:
authorSimon Ser <contact@emersion.fr>2023-11-30 16:38:25 +0100
committerSimon Ser <contact@emersion.fr>2023-11-30 16:38:25 +0100
commit876d789ad5c83029c72f1caeb5a586088ef07225 (patch)
tree8e3482dbb16b39b90610294b73d2a36102c25deb /include/render
parent84bef5c0c23ea54351c16ab3bc79edc8aa498b93 (diff)
render/gles2: reword wlr_gles2_texture comments
These comments were a bit misleading: - "GL_TEXTURE_2D == mutable": not really, imported non-external-only DMA-BUFs would also use this target, but are not mutable. - "Only affects target == GL_TEXTURE_2D": same here. - "If imported from a wlr_buffer": not really, would be NULL if imported from a shm wlr_buffer. Adjust these comments to better reflect reality and adjust the check in gles2_texture_update_from_buffer().
Diffstat (limited to 'include/render')
-rw-r--r--include/render/gles2.h9
1 files changed, 2 insertions, 7 deletions
diff --git a/include/render/gles2.h b/include/render/gles2.h
index 58972675..60bf4d17 100644
--- a/include/render/gles2.h
+++ b/include/render/gles2.h
@@ -118,19 +118,14 @@ struct wlr_gles2_texture {
struct wlr_gles2_renderer *renderer;
struct wl_list link; // wlr_gles2_renderer.textures
- // Basically:
- // GL_TEXTURE_2D == mutable
- // GL_TEXTURE_EXTERNAL_OES == immutable
GLenum target;
bool owns_tex;
GLuint tex;
bool has_alpha;
- // Only affects target == GL_TEXTURE_2D
- uint32_t drm_format; // used to interpret upload data
- // If imported from a wlr_buffer
- struct wlr_gles2_buffer *buffer;
+ uint32_t drm_format; // for mutable textures only, used to interpret upload data
+ struct wlr_gles2_buffer *buffer; // for DMA-BUF imports only
};
struct wlr_gles2_render_pass {