diff options
| author | Simon Ser <contact@emersion.fr> | 2021-08-23 17:41:08 +0200 |
|---|---|---|
| committer | Simon Zeni <simon@bl4ckb0ne.ca> | 2021-08-25 10:05:37 -0400 |
| commit | 5dfaf5ea9ccaeddc236ca103147415b520f73d98 (patch) | |
| tree | 19ca7a4000277e9c9849282bbfe5f4b000f3fed0 /include/backend/drm/util.h | |
| parent | 749b3c00f0d0cb3575c8f058ea8c5e9877d4fd9c (diff) | |
backend/drm: introduce wlr_drm_bo_handle_table
Using GBM to import DRM dumb buffers tends to not work well. By
using GBM we're calling some driver-specific functions in Mesa.
These functions check whether Mesa can work with the buffer.
Sometimes Mesa has requirements which differ from DRM dumb buffers
and the GBM import will fail (e.g. on amdgpu).
Instead, drop GBM and use drmPrimeFDToHandle directly. But there's
a twist: BO handles are not ref'counted by the kernel and need to
be ref'counted in user-space [1]. libdrm usually performs this
bookkeeping and is used under-the-hood by Mesa.
We can't re-use libdrm for this task without using driver-specific
APIs. So let's just re-implement the ref'counting logic in wlroots.
The wlroots implementation is inspired from amdgpu's in libdrm [2].
Closes: https://github.com/swaywm/wlroots/issues/2916
[1]: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/110
[2]: https://gitlab.freedesktop.org/mesa/drm/-/blob/1a4c0ec9aea13211997f982715fe5ffcf19dd067/amdgpu/handle_table.c
Diffstat (limited to 'include/backend/drm/util.h')
| -rw-r--r-- | include/backend/drm/util.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/backend/drm/util.h b/include/backend/drm/util.h index 15895ec6..b4cdee7d 100644 --- a/include/backend/drm/util.h +++ b/include/backend/drm/util.h @@ -13,8 +13,6 @@ void parse_edid(struct wlr_output *restrict output, size_t len, const uint8_t *data); // Returns the string representation of a DRM output type const char *conn_get_name(uint32_t type_id); -// Returns the DRM framebuffer id for a gbm_bo -uint32_t get_fb_for_bo(struct gbm_bo *bo, bool with_modifiers); // Part of match_obj enum { |