output: add wlr_output_state_init()

This changes the semantics of wlr_output_state. Instead of having
fields with uninitialized memory when missing from the committed
bitflag, all fields are always initialized (and maybe NULL/empty),
just like we do in wlr_surface_state. This reduces the chances of
footguns when reading a field, and removes the need to check for
the committed bitfield everywhere.

A new wlr_output_state_init() function takes care of initializing
the Pixman region.

1 files changed, 4 insertions, 2 deletions

diff --git a/examples/output-layers.c b/examples/output-layers.c
index e6ec8150..092394f5 100644
--- a/examples/output-layers.c
+++ b/examples/output-layers.c
@@ -82,7 +82,8 @@ static void output_handle_frame(struct wl_listener *listener, void *data) {
 		};
 	}
 
-	struct wlr_output_state output_state = {0};
+	struct wlr_output_state output_state;
+	wlr_output_state_init(&output_state);
 	wlr_output_state_set_layers(&output_state, layers_arr.data,
 		layers_arr.size / sizeof(struct wlr_output_layer_state));
 
@@ -175,7 +176,8 @@ static void server_handle_new_output(struct wl_listener *listener, void *data) {
 
 	struct wlr_output_mode *mode = wlr_output_preferred_mode(wlr_output);
 	if (mode != NULL) {
-		struct wlr_output_state state = {0};
+		struct wlr_output_state state;
+		wlr_output_state_init(&state);
 		wlr_output_state_set_mode(&state, mode);
 		wlr_output_commit_state(wlr_output, &state);
 		wlr_output_state_finish(&state);