diff options
| author | Simon Ser <contact@emersion.fr> | 2021-06-18 12:15:08 +0200 |
|---|---|---|
| committer | Kenny Levinsen <kl@kl.wtf> | 2021-06-20 23:17:08 +0200 |
| commit | 2f615468b68d49c8ec03ceffa751f8425d4c9b6b (patch) | |
| tree | dff89e08ce6be6041fc9060762ad534166faa9ba /backend/x11 | |
| parent | 15c8453ba11d70e1cc271d5cebed307fe43cd4ba (diff) | |
backend: add output state allow-lists
Right now, when a new output state field is added, all backends by
default won't reject it. This means we need to add new checks to
each and every backend when we introduce a new state field.
Instead, introduce a bitmask of supported output state fields in
each backend, and error out if the user has submitted an unknown
field.
Some fields don't need any backend involvment to work. These are
listed in WLR_OUTPUT_STATE_BACKEND_OPTIONAL as a convenience.
Diffstat (limited to 'backend/x11')
| -rw-r--r-- | backend/x11/output.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/backend/x11/output.c b/backend/x11/output.c index 440e26de..15d1d9a0 100644 --- a/backend/x11/output.c +++ b/backend/x11/output.c @@ -25,6 +25,11 @@ #include "util/signal.h" #include "util/time.h" +static const uint32_t SUPPORTED_OUTPUT_STATE = + WLR_OUTPUT_STATE_BACKEND_OPTIONAL | + WLR_OUTPUT_STATE_BUFFER | + WLR_OUTPUT_STATE_MODE; + static void parse_xcb_setup(struct wlr_output *output, xcb_connection_t *xcb) { const xcb_setup_t *xcb_setup = xcb_get_setup(xcb); @@ -94,8 +99,11 @@ static void output_destroy(struct wlr_output *wlr_output) { } static bool output_test(struct wlr_output *wlr_output) { - if (wlr_output->pending.committed & WLR_OUTPUT_STATE_ENABLED) { - wlr_log(WLR_DEBUG, "Cannot disable an X11 output"); + uint32_t unsupported = + wlr_output->pending.committed & ~SUPPORTED_OUTPUT_STATE; + if (unsupported != 0) { + wlr_log(WLR_DEBUG, "Unsupported output state fields: 0x%"PRIx32, + unsupported); return false; } |