wl_shell: listen for wlr_surface destroy signal

2 files changed, 25 insertions, 3 deletions

diff --git a/include/wlr/types/wlr_wl_shell.h b/include/wlr/types/wlr_wl_shell.h
index 3d190588..11d30d95 100644
--- a/include/wlr/types/wlr_wl_shell.h
+++ b/include/wlr/types/wlr_wl_shell.h
@@ -53,6 +53,8 @@ struct wlr_wl_shell_surface {
 	char *title;
 	char *class;
 
+	struct wl_listener surface_destroy_listener;
+
 	struct {
 		struct wl_signal destroy;
 		struct wl_signal ping_timeout;
diff --git a/types/wlr_wl_shell.c b/types/wlr_wl_shell.c
index 5040850f..99371fb4 100644
--- a/types/wlr_wl_shell.c
+++ b/types/wlr_wl_shell.c
@@ -4,6 +4,7 @@
 #include <assert.h>
 #include <wayland-server.h>
 #include <wlr/util/log.h>
+#include <wlr/types/wlr_surface.h>
 #include <wlr/types/wlr_wl_shell.h>
 #include <stdlib.h>
 #include <wayland-server-protocol.h>
@@ -273,10 +274,11 @@ struct wl_shell_surface_interface shell_surface_interface = {
 	.set_class = shell_surface_set_class,
 };
 
-static void destroy_shell_surface(struct wl_resource *resource) {
-	struct wlr_wl_shell_surface *surface = wl_resource_get_user_data(resource);
+static void wl_shell_surface_destroy(struct wlr_wl_shell_surface *surface) {
 	wl_signal_emit(&surface->events.destroy, surface);
+	wl_resource_set_user_data(surface->resource, NULL);
 	wl_list_remove(&surface->link);
+	wl_list_remove(&surface->surface_destroy_listener.link);
 	free(surface->transient_state);
 	free(surface->popup_state);
 	free(surface->title);
@@ -284,6 +286,20 @@ static void destroy_shell_surface(struct wl_resource *resource) {
 	free(surface);
 }
 
+static void wl_shell_surface_resource_destroy(struct wl_resource *resource) {
+	struct wlr_wl_shell_surface *surface = wl_resource_get_user_data(resource);
+	if (surface != NULL) {
+		wl_shell_surface_destroy(surface);
+	}
+}
+
+static void handle_wlr_surface_destroyed(struct wl_listener *listener,
+		void *data) {
+	struct wlr_wl_shell_surface *surface =
+		wl_container_of(listener, surface, surface_destroy_listener);
+	wl_shell_surface_destroy(surface);
+}
+
 static int wlr_wl_shell_surface_ping_timeout(void *user_data) {
 	struct wlr_wl_shell_surface *surface = user_data;
 	wl_signal_emit(&surface->events.ping_timeout, surface);
@@ -312,7 +328,7 @@ static void wl_shell_get_shell_surface(struct wl_client *client,
 		wl_resource_get_version(resource), id);
 	wlr_log(L_DEBUG, "new wl_shell %p (res %p)", wl_surface, wl_surface->resource);
 	wl_resource_set_implementation(wl_surface->resource,
-			&shell_surface_interface, wl_surface, destroy_shell_surface);
+			&shell_surface_interface, wl_surface, wl_shell_surface_resource_destroy);
 
 	wl_signal_init(&wl_surface->events.destroy);
 	wl_signal_init(&wl_surface->events.ping_timeout);
@@ -324,6 +340,10 @@ static void wl_shell_get_shell_surface(struct wl_client *client,
 	wl_signal_init(&wl_surface->events.set_title);
 	wl_signal_init(&wl_surface->events.set_class);
 
+	wl_signal_add(&wl_surface->surface->signals.destroy,
+		&wl_surface->surface_destroy_listener);
+	wl_surface->surface_destroy_listener.notify = handle_wlr_surface_destroyed;
+
 	struct wl_display *display = wl_client_get_display(client);
 	struct wl_event_loop *loop = wl_display_get_event_loop(display);
 	wl_surface->ping_timer = wl_event_loop_add_timer(loop,