aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Ser <contact@emersion.fr>2023-01-19 17:10:13 +0100
committerAlexander Orzechowski <alex@ozal.ski>2023-01-19 18:50:59 +0000
commit377668aaf6f2d8d0cb11895c4a884c7cfdfe08b6 (patch)
treee0f220be7eb267066c89af395765421af0711260
parent1ba322e9fff2d259bfe55bc43afc1a934ea269a5 (diff)
render/vulkan: check that requested size is smaller than max
Fail with a clearer error when the requested size is too large. Without this, we allocate a buffer with a size smaller than what was requested. References: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3975
-rw-r--r--render/vulkan/renderer.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/render/vulkan/renderer.c b/render/vulkan/renderer.c
index f0acd4cd..fe716240 100644
--- a/render/vulkan/renderer.c
+++ b/render/vulkan/renderer.c
@@ -234,6 +234,13 @@ struct wlr_vk_buffer_span vulkan_get_stage_span(struct wlr_vk_renderer *r,
};
}
+ if (size > max_stage_size) {
+ wlr_log(WLR_ERROR, "cannot vulkan stage buffer: "
+ "requested size (%zu bytes) exceeds maximum (%zu bytes)",
+ (size_t)size, (size_t)max_stage_size);
+ goto error_alloc;
+ }
+
// we didn't find a free buffer - create one
// size = clamp(max(size * 2, prev_size * 2), min_size, max_size)
VkDeviceSize bsize = size * 2;