Merge pull request #1252 from emersion/fatal-unknown-buffer

buffer: disconnect clients that commit an unknown buffer type

1 files changed, 4 insertions, 0 deletions

diff --git a/types/wlr_buffer.c b/types/wlr_buffer.c
index 55ed4792..ce733f40 100644
--- a/types/wlr_buffer.c
+++ b/types/wlr_buffer.c
@@ -87,6 +87,10 @@ struct wlr_buffer *wlr_buffer_create(struct wlr_renderer *renderer,
 		// the buffer yet.
 	} else {
 		wlr_log(WLR_ERROR, "Cannot upload texture: unknown buffer type");
+
+		// Instead of just logging the error, also disconnect the client with a
+		// fatal protocol error so that it's clear something went wrong.
+		wl_resource_post_error(resource, 0, "unknown buffer type");
 		return NULL;
 	}