wlroots.git/xwayland, branch master

xwayland: add map_request signal

2024-02-23T17:46:25+00:00

For XWayland surfaces that start maximized, it's best to send an initial Configure event to set the size of the surface before mapping it. This reduces visual glitches since the application sees the correct maximized size when performing its initial layout and drawing. wlroots surfaces emit their first "map" event after the XWayland window has already been mapped and the first frame has been drawn & committed. This is too late to send the initial Configure event. So, add a new "map_request" event which is emitted immediately before telling XWayland to map the window. Compositors can connect to this event to send the initial Configure event to an XWayland app based on its requested maximized (or fullscreen) state. Compositors should not place anything visually on the screen at this point but rather wait until the "map" event as before.

xwayland/xwm: Initialize client_id_cookie

2024-02-22T22:13:36+00:00

scan-build is a little confused, thinking xwm->xres value could change during the execution of xwayland_surface_create so client_id_cookie could end up used uninitialized. The struct is just an unsigned int, so no harm in initializing it to get it off the list.

xwayland/xwm: Allocate to the right variable

2024-02-22T16:46:05+00:00

837060f894a4 made a change to only allocate the xcb_window_t array if it was not going to be zero-sized. It accidentally shadowed the variable so the output of the allocation would never be used. Regressed-by: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/4563

xwayland/xwm: Avoid zero-size allocaiton

2024-02-22T13:10:46+00:00

Zero-sized allocations have glibc-specific behavior, so avoid those.

Define _POSIX_C_SOURCE globally

2024-02-15T14:41:12+00:00

Stop trying to maintain a per-file _POSIX_C_SOURCE. Instead, require POSIX.1-2008 globally. A lot of core source files depend on that already. Some care must be taken on a few select files where we need a bit more than POSIX. Some files need XSI extensions (_XOPEN_SOURCE) and some files need BSD extensions (_DEFAULT_SOURCE). In both cases, these feature test macros imply _POSIX_C_SOURCE. Make sure to not define both these macros and _POSIX_C_SOURCE explicitly to avoid POSIX requirement conflicts (e.g. _POSIX_C_SOURCE says POSIX.1-2001 but _XOPEN_SOURCE says POSIX.1-2008). Additionally, there is one special case in render/vulkan/vulkan.c. That file needs major()/minor(), and these are system-specific. On FreeBSD, _POSIX_C_SOURCE hides system-specific symbols so we need to make sure it's not defined for this file. On Linux, we can explicitly include and ensure that apart from symbols defined there the file only uses POSIX toys.

xwayland: add support for _NET_WM_WINDOW_TYPE_DESKTOP atom

2024-01-25T16:27:37+00:00

Fix disappearing menus in QT apps

2024-01-25T08:45:05+00:00

A motivating example of such problem - Zoom's popups that open on button presses. Before this fix the popup would flicker and immediately disappear - because the PID is not yet available for the verification (as the surface has not been associated yet), wlroots would refuse to focus the popup and instead focus the previous window. This leads QT to interpret this as a sign to close the popup. This change moves the PID aqcuisition to an earlier phase - just where the window is created.

xwayland/xwm: associate even on xcb_get_property() failure

2024-01-24T09:42:18+00:00

This matches the behavior before f5797be8a8d410e22fa6397b2217a6a81858d05c.

xwayland: close pipe fds on set_cloexec() error

2024-01-17T15:44:37+00:00

xwm: don't do anything except mapping on MapRequest

2023-11-27T10:21:17+00:00

Instead, move the wlr_xwayland_surface_set_withdrawn() and wlr_xwayland_surface_restack() calls to the MapNotify handler with an override_redirect check, as they are done too early. This mirrors the logic in the UnmapNotify handler and fixes a bug where wlr_xwayland_surface_restack() would be called on an o-r window after the following sequence of requests: - CreateWindow with override_redirect=True - ChangeWindowAttributes with override_redirect=False - MapWindow Fixes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3770