wlroots.git/xwayland/selection, branch master

Define _POSIX_C_SOURCE globally

2024-02-15T14:41:12+00:00

Stop trying to maintain a per-file _POSIX_C_SOURCE. Instead, require POSIX.1-2008 globally. A lot of core source files depend on that already. Some care must be taken on a few select files where we need a bit more than POSIX. Some files need XSI extensions (_XOPEN_SOURCE) and some files need BSD extensions (_DEFAULT_SOURCE). In both cases, these feature test macros imply _POSIX_C_SOURCE. Make sure to not define both these macros and _POSIX_C_SOURCE explicitly to avoid POSIX requirement conflicts (e.g. _POSIX_C_SOURCE says POSIX.1-2001 but _XOPEN_SOURCE says POSIX.1-2008). Additionally, there is one special case in render/vulkan/vulkan.c. That file needs major()/minor(), and these are system-specific. On FreeBSD, _POSIX_C_SOURCE hides system-specific symbols so we need to make sure it's not defined for this file. On Linux, we can explicitly include and ensure that apart from symbols defined there the file only uses POSIX toys.

treewide: Migrate from sizeof(struct) to sizeof(*pointer) where practical

2023-10-03T05:51:07+00:00

xwayland: avoid calling xwm_get_atom_name() when debug logs are off

2023-07-28T12:21:37+00:00

xwm_get_atom_name() performs a roundtrip to the X11 server. Avoid calling this blocking function if debug logs are turned off.

Use wl_container_of() instead of casts

2023-07-11T18:16:17+00:00

This slightly improves type safety. The culprits were found with: git grep -E '\([a-z0-9_ ]+ \*\)\W?[a-z]'

Use struct initializers instead of memset()

2023-07-07T15:31:11+00:00

This is a bit more type-safe.

Zero-initialize structs in init functions

2022-04-28T08:09:50+00:00

Ensures there is no field left to its previous undefined value after calling an init function.

gtk-primary-selection: drop support

2021-04-08T07:50:18+00:00

The standard primary-selection protocol is now widely supported.

xwayland/selection: flush connection after changing xwm selection owner

2021-02-15T12:50:14+00:00

This was the actual underlying cause of #2192; we were not getting the XFIXES_SELECTION_NOTIFY event in time.

xwayland/selection: log when proxy window loses ownership

2021-02-15T12:50:14+00:00

xwayland/selection: ignore requests for anything but the newest data

2021-02-15T12:50:14+00:00

Our internal state machine gets screwed up if selection events are not monotonically increasing in time, and we can enter a self-copy loop from the proxy window that exhausts all pipes. Snippet of logs when this occurs: 00:00:46.238 [wlr] [xwayland/selection/incoming.c:487] XCB_XFIXES_SELECTION_NOTIFY (selection=277, owner=4194626) 00:00:46.238 [wlr] [xwayland/selection/incoming.c:487] XCB_XFIXES_SELECTION_NOTIFY (selection=277, owner=2097153) 00:00:46.238 [wlr] [xwayland/selection/outgoing.c:378] XCB_SELECTION_REQUEST (time=58979563 owner=2097153, requestor=2097153 selection=277, target=279, property=278) 00:00:46.238 [wlr] [xwayland/selection/outgoing.c:397] ignoring old request from timestamp 58979563; expecting > 58979563 00:00:46.238 [wlr] [xwayland/selection/outgoing.c:29] SendEvent destination=2097153 SelectionNotify(31) time=58979563 requestor=2097153 selection=277 target=279 property=0 00:00:46.238 [wlr] [xwayland/selection/incoming.c:453] XCB_SELECTION_NOTIFY (selection=277, property=0, target=279) Note that 2097153 is `selection->window`, and 4194626 is Emacs. The race occurs if the selection owner changes back to our proxy window between when we get `XCB_XFIXES_SELECTION_NOTIFY` for Emacs and when we call `xcb_convert_selection` in `incoming.c:source_send` -- the ConvertSelection request can end up hitting our proxy window, but the timestamp will be rejected. Fixes #2192.