From 418915eeba5679832d6a7b50ece02482347056a4 Mon Sep 17 00:00:00 2001 From: Jonas Ådahl Date: Wed, 9 Mar 2016 15:49:51 +0800 Subject: Revert "xdg-shell: clarify xdg_surface creation semantics regarding buffers" This patch was intended to be part of the coming v6 version of the xdg_shell protocol. It is an semantically backward incompatible change, so it cannot be implemented in xdg_shell v5 without breaking compatibility with available clients. This reverts commit 275fd34023fabdcb487f2adf2fe80bda1e4bf0dc. --- unstable/xdg-shell/xdg-shell-unstable-v5.xml | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'unstable') diff --git a/unstable/xdg-shell/xdg-shell-unstable-v5.xml b/unstable/xdg-shell/xdg-shell-unstable-v5.xml index 0b99326..542491f 100644 --- a/unstable/xdg-shell/xdg-shell-unstable-v5.xml +++ b/unstable/xdg-shell/xdg-shell-unstable-v5.xml @@ -147,12 +147,14 @@ them, and associate metadata like title and app id. The client must call wl_surface.commit on the corresponding wl_surface - for the xdg_surface state to take effect. - - Creating an xdg_surface from a wl_surface which has a buffer attached or - committed is a client error, and any attempts by a client to attach or - manipulate a buffer prior to the first xdg_surface.configure call must - also be treated as errors. + for the xdg_surface state to take effect. Prior to committing the new + state, it can set up initial configuration, such as maximizing or setting + a window geometry. + + Even without attaching a buffer the compositor must respond to initial + committed configuration, for instance sending a configure event with + expected window geometry if the client maximized its surface during + initialization. For a surface to be mapped by the compositor the client must have committed both an xdg_surface state and a buffer. -- cgit v1.2.3