From c62be976d712b82ea676de7e64bf333b43492d0e Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Mon, 27 Sep 2021 11:13:39 +0200 Subject: linux-dmabuf: send protocol error on invalid format/modifier Now that compositors must send INVALID to advertise support for implicit modifiers, we can make it a protocol error to add a DMA-BUF plane with an unsupported format + modifier pair. Signed-off-by: Simon Ser Reviewed-by: Daniel Stone --- unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml index 14cf242..018f876 100644 --- a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml +++ b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml @@ -247,10 +247,8 @@ compression, etc. driver-specific modifications to the base format defined by the DRM fourcc code. - Warning: It should be an error if the format/modifier pair was not - advertised by zwp_linux_dmabuf_feedback_v1. This is not enforced yet - because some implementations always accept DRM_FORMAT_MOD_INVALID. Also - version 2 of this protocol does not have the modifier event. + Starting from version 4, the invalid_format protocol error is sent if + the format + modifier pair was not advertised as supported. This request raises the PLANE_IDX error if plane_idx is too large. The error PLANE_SET is raised if attempting to set a plane that -- cgit v1.2.3