diff options
author | Simon Ser <contact@emersion.fr> | 2021-03-23 23:08:00 +0100 |
---|---|---|
committer | Simon Ser <contact@emersion.fr> | 2021-03-31 07:24:53 +0000 |
commit | 3683a5eb6642422c50d3beeb236a0e52b72971f6 (patch) | |
tree | 2bb2a553ddcdb92702aa4faef59f57dfdf8a6d6f /.gitignore | |
parent | 42da22947b0808d73a63c7f8f6b16efe7944f729 (diff) |
linux-dmabuf: clarify what mixed valid/INVALID modifiers mean
This commit makes it clear that compositors can send valid modifiers and
DRM_FORMAT_MOD_INVALID for a given format. This means that the compositor
supports both implicit and explicit modifiers. See the warning further
down:
> Warning: It should be an error if the format/modifier pair was not
> advertised with the modifier event. This is not enforced yet because
> some implementations always accept DRM_FORMAT_MOD_INVALID. Also
> version 2 of this protocol does not have the modifier event.
Xwayland already requires compositors to send DRM_FORMAT_MOD_INVALID
for importing buffers with an implicit modifier [1].
In a future protocol version, it would be nice to make it a protocol
error (or at least a soft failure) to use any format/modifier pair that
wasn't advertised. A use-case for this is Vulkan compositors: the Vulkan
DMA-BUF extensions require an explicit modifier and cannot import
buffers which have an implicit modifier.
[1]: https://gitlab.freedesktop.org/xorg/xserver/-/blob/6c51818a0f55282cbe5a870f58ca82ca45ee472d/hw/xwayland/xwayland-glamor-gbm.c#L328
Signed-off-by: Simon Ser <contact@emersion.fr>
Diffstat (limited to '.gitignore')
0 files changed, 0 insertions, 0 deletions