From d3f0e52784712696c7174d3adf8ec6cf3ac31b19 Mon Sep 17 00:00:00 2001 From: Brian Ashworth Date: Tue, 9 Oct 2018 08:12:02 -0400 Subject: bar-bindsym: address ianyfan's comments --- sway/config/bar.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'sway/config') diff --git a/sway/config/bar.c b/sway/config/bar.c index f84407c9..c6899f57 100644 --- a/sway/config/bar.c +++ b/sway/config/bar.c @@ -32,9 +32,7 @@ void free_bar_binding(struct bar_binding *binding) { if (!binding) { return; } - if (binding->command) { - free(binding->command); - } + free(binding->command); free(binding); } @@ -49,9 +47,8 @@ void free_bar_config(struct bar_config *bar) { free(bar->status_command); free(bar->font); free(bar->separator_symbol); - while (bar->bindings->length) { - struct bar_binding *binding = bar->bindings->items[0]; - list_del(bar->bindings, 0); + for (int i = 0; i < bar->bindings->length; i++) { + struct bar_binding *binding = bar->bindings->items[i]; free_bar_binding(binding); } list_free(bar->bindings); -- cgit v1.2.3