From c006717910e5f30ca65645f701541dfa176c1392 Mon Sep 17 00:00:00 2001 From: Ryan Dwyer Date: Thu, 18 Oct 2018 21:20:00 +1000 Subject: Minor refactor of input manager The input manager is a singleton object. Passing the sway_input_manager argument to each of its functions is unnecessary, while removing the argument makes it obvious to the caller that it's a singleton. This patch removes the argument and makes the input manager use server.input instead. On a similar note: * sway_input_manager.server is removed in favour of using the server global. * seat.input is removed because it can get it from server.input. Due to a circular dependency, creating seat0 is now done directly in server_init rather than in input_manager_create. This is because creating seats must be done after server.input is set. Lastly, it now stores the default seat name using a constant and removes a second reference to seat0 (in input_manager_get_default_seat). --- sway/commands/border.c | 2 +- sway/commands/input.c | 2 +- sway/commands/move.c | 2 +- sway/commands/scratchpad.c | 2 +- sway/commands/swap.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) (limited to 'sway/commands') diff --git a/sway/commands/border.c b/sway/commands/border.c index a50f7a1c..5b65148d 100644 --- a/sway/commands/border.c +++ b/sway/commands/border.c @@ -94,7 +94,7 @@ struct cmd_results *cmd_border(int argc, char **argv) { arrange_container(view->container); - struct sway_seat *seat = input_manager_current_seat(input_manager); + struct sway_seat *seat = input_manager_current_seat(); if (seat->cursor) { cursor_rebase(seat->cursor); } diff --git a/sway/commands/input.c b/sway/commands/input.c index 2889d47d..c50926a8 100644 --- a/sway/commands/input.c +++ b/sway/commands/input.c @@ -71,7 +71,7 @@ struct cmd_results *cmd_input(int argc, char **argv) { struct input_config *ic = store_input_config(config->handler_context.input_config); - input_manager_apply_input_config(input_manager, ic); + input_manager_apply_input_config(ic); } else { free_input_config(config->handler_context.input_config); } diff --git a/sway/commands/move.c b/sway/commands/move.c index cb7f6009..941b284a 100644 --- a/sway/commands/move.c +++ b/sway/commands/move.c @@ -103,7 +103,7 @@ static void workspace_focus_fullscreen(struct sway_workspace *workspace) { } struct sway_seat *seat; struct sway_workspace *focus_ws; - wl_list_for_each(seat, &input_manager->seats, link) { + wl_list_for_each(seat, &server.input->seats, link) { focus_ws = seat_get_focused_workspace(seat); if (focus_ws == workspace) { struct sway_node *new_focus = diff --git a/sway/commands/scratchpad.c b/sway/commands/scratchpad.c index d8bae615..26f0e490 100644 --- a/sway/commands/scratchpad.c +++ b/sway/commands/scratchpad.c @@ -8,7 +8,7 @@ #include "sway/tree/workspace.h" static void scratchpad_toggle_auto(void) { - struct sway_seat *seat = input_manager_current_seat(input_manager); + struct sway_seat *seat = input_manager_current_seat(); struct sway_container *focus = seat_get_focused_container(seat); struct sway_workspace *ws = seat_get_focused_workspace(seat); diff --git a/sway/commands/swap.c b/sway/commands/swap.c index 8a6dfdbd..6062724d 100644 --- a/sway/commands/swap.c +++ b/sway/commands/swap.c @@ -108,7 +108,7 @@ static void container_swap(struct sway_container *con1, container_set_fullscreen(con2, false); } - struct sway_seat *seat = input_manager_get_default_seat(input_manager); + struct sway_seat *seat = input_manager_get_default_seat(); struct sway_container *focus = seat_get_focused_container(seat); struct sway_workspace *vis1 = output_get_active_workspace(con1->workspace->output); -- cgit v1.2.3