From 832ebc896655cb5ca7689559d4e42b426d764e71 Mon Sep 17 00:00:00 2001
From: Ryan Dwyer <ryandwyer1@gmail.com>
Date: Sun, 7 Oct 2018 20:40:05 +1000
Subject: Implement popup_during_fullscreen

This introduces a new view_impl function: is_transient_for. Similar to
container_has_ancestor but works using the surface parents rather than
the tree.

This patch modifies view_is_visible, container_at and so on to allow
transient views to function normally when they're in front of a
fullscreen view.
---
 include/sway/commands.h  | 1 +
 include/sway/config.h    | 7 +++++++
 include/sway/tree/view.h | 4 ++++
 3 files changed, 12 insertions(+)

(limited to 'include')

diff --git a/include/sway/commands.h b/include/sway/commands.h
index 21b8b87a..48228a98 100644
--- a/include/sway/commands.h
+++ b/include/sway/commands.h
@@ -154,6 +154,7 @@ sway_cmd cmd_new_window;
 sway_cmd cmd_no_focus;
 sway_cmd cmd_output;
 sway_cmd cmd_permit;
+sway_cmd cmd_popup_during_fullscreen;
 sway_cmd cmd_reject;
 sway_cmd cmd_reload;
 sway_cmd cmd_rename;
diff --git a/include/sway/config.h b/include/sway/config.h
index 0e51fbfb..00b5f25b 100644
--- a/include/sway/config.h
+++ b/include/sway/config.h
@@ -256,6 +256,12 @@ enum edge_border_types {
 	E_SMART_NO_GAPS, /**< hide both if one window and gaps to edge is zero */
 };
 
+enum sway_popup_during_fullscreen {
+	POPUP_SMART,
+	POPUP_IGNORE,
+	POPUP_LEAVE,
+};
+
 enum command_context {
 	CONTEXT_CONFIG = 1,
 	CONTEXT_BINDING = 2,
@@ -355,6 +361,7 @@ struct sway_config {
 	bool pango_markup;
 	size_t urgent_timeout;
 	enum sway_fowa focus_on_window_activation;
+	enum sway_popup_during_fullscreen popup_during_fullscreen;
 
 	// Flags
 	bool focus_follows_mouse;
diff --git a/include/sway/tree/view.h b/include/sway/tree/view.h
index 028be536..eb1e98e1 100644
--- a/include/sway/tree/view.h
+++ b/include/sway/tree/view.h
@@ -49,6 +49,8 @@ struct sway_view_impl {
 		wlr_surface_iterator_func_t iterator, void *user_data);
 	void (*for_each_popup)(struct sway_view *view,
 		wlr_surface_iterator_func_t iterator, void *user_data);
+	bool (*is_transient_for)(struct sway_view *child,
+			struct sway_view *ancestor);
 	void (*close)(struct sway_view *view);
 	void (*close_popups)(struct sway_view *view);
 	void (*destroy)(struct sway_view *view);
@@ -396,4 +398,6 @@ void view_remove_saved_buffer(struct sway_view *view);
 
 void view_save_buffer(struct sway_view *view);
 
+bool view_is_transient_for(struct sway_view *child, struct sway_view *ancestor);
+
 #endif
-- 
cgit v1.2.3


From f23588de3c7085830614f6764a5c0cd262538afd Mon Sep 17 00:00:00 2001
From: Ryan Dwyer <ryandwyer1@gmail.com>
Date: Mon, 8 Oct 2018 23:00:36 +1000
Subject: Introduce container_is_transient_for

---
 include/sway/tree/container.h |  3 +++
 sway/desktop/output.c         | 15 ++++++---------
 sway/desktop/render.c         | 12 ++++--------
 sway/input/cursor.c           | 18 +++++++-----------
 sway/input/seat.c             |  6 +-----
 sway/tree/container.c         |  7 +++++++
 sway/tree/view.c              |  6 ++----
 7 files changed, 30 insertions(+), 37 deletions(-)

(limited to 'include')

diff --git a/include/sway/tree/container.h b/include/sway/tree/container.h
index da6592b4..920ef038 100644
--- a/include/sway/tree/container.h
+++ b/include/sway/tree/container.h
@@ -292,4 +292,7 @@ bool sway_dir_to_wlr(enum movement_direction dir, enum wlr_direction *out);
 struct sway_container *container_split(struct sway_container *child,
 		enum sway_container_layout layout);
 
+bool container_is_transient_for(struct sway_container *child,
+		struct sway_container *ancestor);
+
 #endif
diff --git a/sway/desktop/output.c b/sway/desktop/output.c
index 0bcdcac1..adc1ee10 100644
--- a/sway/desktop/output.c
+++ b/sway/desktop/output.c
@@ -329,15 +329,12 @@ static void send_frame_done(struct sway_output *output, struct timespec *when) {
 				workspace->current.fullscreen, &data);
 		container_for_each_child(workspace->current.fullscreen,
 				send_frame_done_container_iterator, &data);
-		if (config->popup_during_fullscreen == POPUP_SMART &&
-				workspace->current.fullscreen->view) {
-			for (int i = 0; i < workspace->current.floating->length; ++i) {
-				struct sway_container *floater =
-					workspace->current.floating->items[i];
-				if (floater->view && view_is_transient_for(floater->view,
-							workspace->current.fullscreen->view)) {
-					send_frame_done_container_iterator(floater, &data);
-				}
+		for (int i = 0; i < workspace->current.floating->length; ++i) {
+			struct sway_container *floater =
+				workspace->current.floating->items[i];
+			if (container_is_transient_for(floater,
+						workspace->current.fullscreen)) {
+				send_frame_done_container_iterator(floater, &data);
 			}
 		}
 #ifdef HAVE_XWAYLAND
diff --git a/sway/desktop/render.c b/sway/desktop/render.c
index c2a0d29f..765317db 100644
--- a/sway/desktop/render.c
+++ b/sway/desktop/render.c
@@ -962,14 +962,10 @@ void output_render(struct sway_output *output, struct timespec *when,
 					fullscreen_con->current.focused);
 		}
 
-		if (config->popup_during_fullscreen == POPUP_SMART &&
-				fullscreen_con->view) {
-			for (int i = 0; i < workspace->floating->length; ++i) {
-				struct sway_container *floater = workspace->floating->items[i];
-				if (floater->view && view_is_transient_for(
-							floater->view, fullscreen_con->view)) {
-					render_floating_container(output, damage, floater);
-				}
+		for (int i = 0; i < workspace->floating->length; ++i) {
+			struct sway_container *floater = workspace->floating->items[i];
+			if (container_is_transient_for(floater, fullscreen_con)) {
+				render_floating_container(output, damage, floater);
 			}
 		}
 #ifdef HAVE_XWAYLAND
diff --git a/sway/input/cursor.c b/sway/input/cursor.c
index 08eeb812..6d57c45f 100644
--- a/sway/input/cursor.c
+++ b/sway/input/cursor.c
@@ -99,17 +99,13 @@ static struct sway_node *node_at_coords(
 	}
 	if (ws->fullscreen) {
 		// Try transient containers
-		if (config->popup_during_fullscreen == POPUP_SMART &&
-				ws->fullscreen->view) {
-			for (int i = 0; i < ws->floating->length; ++i) {
-				struct sway_container *floater = ws->floating->items[i];
-				if (floater->view && view_is_transient_for(
-							floater->view, ws->fullscreen->view)) {
-					struct sway_container *con = tiling_container_at(
-							&floater->node, lx, ly, surface, sx, sy);
-					if (con) {
-						return &con->node;
-					}
+		for (int i = 0; i < ws->floating->length; ++i) {
+			struct sway_container *floater = ws->floating->items[i];
+			if (container_is_transient_for(floater, ws->fullscreen)) {
+				struct sway_container *con = tiling_container_at(
+						&floater->node, lx, ly, surface, sx, sy);
+				if (con) {
+					return &con->node;
 				}
 			}
 		}
diff --git a/sway/input/seat.c b/sway/input/seat.c
index 690b59e6..f418785d 100644
--- a/sway/input/seat.c
+++ b/sway/input/seat.c
@@ -656,11 +656,7 @@ void seat_set_focus_warp(struct sway_seat *seat, struct sway_node *node,
 	if (new_workspace && new_workspace->fullscreen && container &&
 			!container_is_fullscreen_or_child(container)) {
 		// Unless it's a transient container
-		bool is_transient = new_workspace->fullscreen->view &&
-			config->popup_during_fullscreen == POPUP_SMART &&
-			container->view && view_is_transient_for(
-					container->view, new_workspace->fullscreen->view);
-		if (!is_transient) {
+		if (!container_is_transient_for(container, new_workspace->fullscreen)) {
 			return;
 		}
 	}
diff --git a/sway/tree/container.c b/sway/tree/container.c
index 9db7aed1..1664514a 100644
--- a/sway/tree/container.c
+++ b/sway/tree/container.c
@@ -1212,3 +1212,10 @@ struct sway_container *container_split(struct sway_container *child,
 
 	return cont;
 }
+
+bool container_is_transient_for(struct sway_container *child,
+		struct sway_container *ancestor) {
+	return config->popup_during_fullscreen == POPUP_SMART &&
+		child->view && ancestor->view &&
+		view_is_transient_for(child->view, ancestor->view);
+}
diff --git a/sway/tree/view.c b/sway/tree/view.c
index edf771c1..b107d871 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -1044,10 +1044,8 @@ bool view_is_visible(struct sway_view *view) {
 			!container_is_fullscreen_or_child(view->container)) {
 		// However, if we're transient for the fullscreen view and we allow
 		// "popups" during fullscreen then it might be visible
-		bool is_transient = config->popup_during_fullscreen == POPUP_SMART &&
-				workspace->fullscreen->view &&
-				view_is_transient_for(view, workspace->fullscreen->view);
-		if (!is_transient) {
+		if (!container_is_transient_for(view->container,
+					workspace->fullscreen)) {
 			return false;
 		}
 	}
-- 
cgit v1.2.3