aboutsummaryrefslogtreecommitdiff
path: root/sway
AgeCommit message (Collapse)Author
2018-09-28Move sticky containers in output_evacuateBrian Ashworth
2018-09-28sway{,bar,input}.5: changes for generic blocksBrian Ashworth
2018-09-28sway.5: update set command informationBrian Ashworth
2018-09-28swaybar: fix setting binding mode indicatorIan Fan
2018-09-28Check for NULL output in workspace_valid_on_outputRyan Dwyer
2018-09-28Rename workspace_outputs to workspace_configs and fix memory leakRyan Dwyer
When we eventually implement `workspace <ws> gaps inner|outer <px>`, we'll need to store the gaps settings for workspaces before they're created. Rather than create a workspace_gaps struct, the approach I'm taking is to rename workspace_outputs to workspace_configs and then add gaps settings to that. I've added a lookup function workspace_find_config. Note that we have a similar thing for outputs (output_config struct and output_find_config). Lastly, when freeing config it would create a memory leak by freeing the list items but not the workspace or output names inside them. This has been rectified using a free_workspace_config function.
2018-09-28transaction: do not use pointers for stateIan Fan
2018-09-28Fix floating views in tabbed/stacked workspaces not getting frame eventsRyan Dwyer
view_is_visible would return false, which meant the view wouldn't receive a frame done event. view_is_visible needs to make an exception for floating containers. This also moves the workspace_is_visible check to an earlier location for performance reasons.
2018-09-27input config: merge left_handed optionIan Fan
2018-09-27Merge pull request #2704 from ianyfan/tablet-configDrew DeVault
input: enable configuring tablets with libinput
2018-09-26Make sway/ipc-server.c POSIX 2001 compliantsghctoma
This commit replaces the non-standard SOCK_NONBLOCK and SOCK_CLOEXEC flags with two fcntl calls. This makes the file POSIX 2001 compliant, thus it is no longer necessary to conditionally define, or use internal (__BSD_VISIBLE) feature test macros.
2018-09-26Fix race condition crash when view unmaps + maps quicklyRyan Dwyer
When a view unmaps, we start a transaction to destroy the container, then when the transaction completes we destroy the container and unset the view's container pointer. But if the view has remapped in the meantime, the view's container pointer will be pointing to a different container which should not be cleared. This adds a check to make sure the view is still pointing to the container being destroyed before clearing the pointer. The freeing of the title format is also removed as it is already freed when the view destroys in view_destroy.
2018-09-25Add a missing null check for moving tiling containersAlexander Bakker
2018-09-25Fix crash when disconnecting outputRyan Dwyer
If the output being disconnected contains views, and the views are being relocated to another output of a different size, a transaction must occur to reconfigure them. This means by the time container_discover_outputs is called, the output is already disabled and wlr_output is NULL. I considered making it check output->wlr_output, but output->enabled should work just as well and is more descriptive.
2018-09-24input: enable configuring tablets with libinputIan Fan
2018-09-23Implement support for input wildcardBrian Ashworth
2018-09-23Fix GtkMenuBar always opening first itemRyan Dwyer
It seems like advertising that we support touch when we don't, while using SSD, makes GtkMenuBar misbehave. Please don't ask me why...
2018-09-23Merge pull request #2695 from RyanDwyer/remove-moveoutoftabsstacksDrew DeVault
Remove move_out_of_tabs_stacks
2018-09-23Merge pull request #2694 from RyanDwyer/fix-sticky-jumping-on-switchemersion
Prevent sticky containers from jumping on workspace switch
2018-09-23Merge pull request #2686 from RyanDwyer/tab-scrollingemersion
Implement tab cycling using mouse wheel
2018-09-23Flatten container in workspace_rejiggerRyan Dwyer
2018-09-23Fix some bugs as a result of removing move_out_of_tabs_stacksRyan Dwyer
2018-09-23Remove move_out_of_tabs_stacksRyan Dwyer
This fixes the following. Create these layouts and run move right: (Initial layout -> expected result -> actual result) * `H[S[unfocused focused] unfocused]` -> `H[S[unfocused] focused unfocused]` -> `H[H[S[unfocused] focused] unfocused]` * `H[S[unfocused focused] V[unfocused]]` -> `H[S[unfocused] V[unfocused focused]]` -> `H[H[S[unfocused] focused] V[unfocused]]` move_out_of_tabs_stacks was originally made to allow views to move out of the tabbed/stacked container in the parallel direction, but at some point this has started working using the regular logic.
2018-09-23Prevent sticky containers from jumping on workspace switchRyan Dwyer
If you have swaybar docked to the top, and you create a floating sticky container and switch workspaces on the same output, the sticky container would move down by the height of swaybar on each switch. This happens because when creating the workspace we set the dimensions to the same as the output, then the subsequent arrange corrects it. During this arrange, floating containers are translated so they stay relative to the workspace. This translation needs to not occur for the initial arrange. This patch makes workspaces have a zero width and height when first created, so we can detect whether this is the initial arrange and avoid translating the floating containers if so.
2018-09-22Merge pull request #2688 from RyanDwyer/exec-commands-without-focusDrew DeVault
Allow running commands on containers without focusing them
2018-09-23Allow running commands on containers without focusing themRyan Dwyer
This adds a `con` argument to `execute_command` which allows you to specify the container to execute the command on. In most cases it leaves it as `NULL` which makes it use the focused node. We only set it when executing `for_window` criteria such as when a view maps. This means we don't send unnecessary IPC focus events, and fixes a crash when the criteria command is `move scratchpad` (because we can't give focus to a hidden scratchpad container). Each of the shell map handlers now check to see if the view has a workspace. It won't have a workspace if criteria has moved it to the scratchpad.
2018-09-22commands: remove obselete code for sticky windows when switching workspaceIan Fan
2018-09-22swaybar, swaylock, & tree/container: Set cairo font options to render text ↵Geoff Greer
and lines with subpixel hinting (if available).
2018-09-22Merge pull request #2660 from RyanDwyer/fix-scratchpad-iterationemersion
Fix double iteration of scratchpad containers
2018-09-22Fix pango escaping and refactor escape_markup_textRyan Dwyer
Fixes #2674. The cause of the issue was in get_pango_layout. When we call pango_parse_markup, `text` is the escaped string, and the unescaped string is then computed and written to `buf`. We were then passing the unescaped string to pango_layout_set_markup, but this function needs the escaped string. `buf` is not needed and has been removed. The other part of this PR refactors escape_markup_text to remove the dest_length argument and removes the -1 return value on error. It now assumes that you've allocated dest to the correct length.
2018-09-22Merge pull request #2678 from RyanDwyer/reconfigure-on-repositionemersion
Reconfigure xwayland views when repositioned
2018-09-22Implement tab cycling using mouse wheelRyan Dwyer
Firstly, a change had to be made to the container_at functions. If you create layout `T[view H[view view]]` and hover the second tab, the container_at functions would return the focus_inactive child. They now return the split container itself. To compensate for this, dispatch_cursor_button has been adjusted to find the focus_inactive child before focusing it. The actual implementation of wheel scrolling is pretty straightforward. This uses handle_cursor_axis, so I took a similar approach to handle_cursor_button (ie. creating a dispatch_cursor_axis function).
2018-09-21Merge branch 'master' into swaybar-hotplugBrian Ashworth
2018-09-21Reconfigure xwayland views when repositionedRyan Dwyer
Fixes #2673.
2018-09-21Fix compilation against wlroots without X11 backendMarien Zwart
2018-09-21Merge branch 'master' into render-output-segfaultRyan Dwyer
2018-09-20swaybar: handle hotpluggingemersion
Don't kill and respawn swaybars on hotplug.
2018-09-20Merge pull request #2671 from emersion/output-execute-no-focusemersion
Fix segfault when executing command without focus
2018-09-19Merge pull request #2676 from ianyfan/ipcDrew DeVault
ipc: add pid information for views in layout tree
2018-09-19ipc: add pid information for views in layout treeIan Fan
2018-09-19Fix segfault when executing command without focusemersion
2018-09-19Merge branch 'master' into create-output-commandemersion
2018-09-19config: free strings fields when freeing input configIan Fan
2018-09-19Introduce create_output command (for developer use)Ryan Dwyer
Should help with testing hotplugging.
2018-09-19Fix segfault in output_renderemersion
2018-09-18Fix double iteration of scratchpad containersRyan Dwyer
root_for_each_container and root_find_container were using incorrect logic to determine if a container was hidden in the scratchpad. Containers will have a NULL parent if they are a direct child of a workspace. Containers will have a NULL workspace if they are hidden in the scratchpad. The incorrect check meant that root_for_each_container would run the callback on scratchpad containers twice. This meant that executing a command such as `[class="$something"] scratchpad show` would cause the command to run twice, resulting in the container being shown and hidden again which is effectively a no op. Fixes #2655.
2018-09-17Fix crash moving out of tab containerWilliam Wold
2018-09-16Merge pull request #2637 from RyanDwyer/fix-tabbed-workspace-shenanigansDrew DeVault
Make seat_get_active_child ignore floating children
2018-09-16Fix crash when destroying an idle-inhibiting clientMarien Zwart
When destroying an idle-inhibiting client, idle_inhibit_v1_check_active can get called from transaction_progress_queue on a view with a null container. view_is_visible does not handle a view in this state.
2018-09-16Rename seat_get_active_child to seat_get_active_tiling_childRyan Dwyer
Also renames container to con in one function to prevent ugly line wrapping.