aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-03-15Updating criteria checking with PCRE2Bill Li
2022-03-14swaybar: set opaque regionSimon Ser
When the background color is fully opaque, set the surface's opaque region to the whole surface.
2022-03-14swaybar: remove swaybar_output.input_regionSimon Ser
No need to keep the region around, we can immediately destroy it after the wl_surface.set_input_region request.
2022-03-12Replace pcre with pcre2ndren
Closes: https://github.com/swaywm/sway/issues/6838
2022-03-08Remove WLR_SWITCH_STATE_TOGGLE usageSimon Ser
Ref [1]. [1]: https://gitlab.freedesktop.org/wlroots/wlroots/-/commit/4792446ee8f50104bd207d9ccd8558a7e4eb4514
2022-03-06commands/focus: fix segfault when no container is already focused.Nicolas Avrutin
Fixes #6690.
2022-03-05sway/input: destroy sway_switch properlyMoon Sungjoon
Fix: #6861 Added seat_device_destroy function to seat_device_destroy function.
2022-03-04sway/input: don't pass possibly invalid modifiers pointerAlexander Gramiak
active_keyboard may be NULL, in which case an invalid pointer could be passed to wlr_input_method_keyboard_grab_v2_send_modifiers. This procedure call is unnecessary since wlroots commit 372a52ec "input method: send modifiers in set_keyboard", so the call can simply be removed. Fixes #6836.
2022-02-28swaynag: die on all allocation failuresNihal Jere
2022-02-24Don't enter seatop_move_floating when fullscreenThomas Hebb
Currently, a floating window that's been fullscreened can send us xdg_toplevel::move, and we'll enter seatop_move_floating, which lets us drag the surface around while it's fullscreen. We don't want this--fullscreen surfaces should always be aligned to the screen--so add the same check that seatop_default already does when entering this mode. Tested with Weston's weston-fullscreen demo, which sends a move request if you click anywhere on its surface.
2022-02-22Remove some erroneous apostrophes in commentsThomas Hebb
2022-02-21sway/input: use wlr_input_device from input device baseSimon Zeni
2022-02-21sway/commands: add missing wlr_keyboard interface include in xkb_switch_layoutSimon Zeni
2022-02-08Remove all sprintf callsSimon Ser
Replace them with snprintf, which ensures buffer overflows won't happen.
2022-02-08Fix snprintf compiler warningMuhamed Hobi
2022-02-07xdg-shell: use wlr_xdg_popup in sway_xdg_popupSimon Ser
Improved type safety.
2022-02-07xdg-shell: use wlr_xdg_toplevel in sway_viewSimon Ser
Improved type safety. Closes: https://github.com/swaywm/sway/issues/6813
2022-02-07readme: use relative links for translationsSimon Ser
2022-02-07readme: sort language list alphabeticallySimon Ser
2022-02-07readme: add link to Italian translationSimon Ser
2022-02-07Translated README into ItalianMarco Rubin
2022-02-06Minor update to focus_on_window_activationAlexander Browne
Removed xwayland limitation since wayland clients are supported via xdg-activation.
2022-02-03Chase wlroots xdg-shell refactorKirill Primak
2022-01-31chore: chase wlr_output_layout_get_box() updateKirill Primak
https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3439
2022-01-31xwayland: listen to `request_activate` eventTuomas Yrjölä
When REAPER submenu is closed `XCB_CLIENT_MESSAGE` with type `NET_ACTIVE_WINDOW` is sent to set focus to parent menu. Closes: https://github.com/swaywm/sway/issues/6324
2022-01-31Use bools for CLI flagsSimon Ser
2022-01-23swaynag: remove buffer destruction conditionKirill Primak
An address of a variable can never be NULL, so checking it doesn't make sense; and `destroy_buffer()` can operate on already destroyed buffers anyway. Fixes #6780
2022-01-22input/cursor: pass through pointer hold gesturesTudor Brindus
This just follows swaywm/wlroots#3047, so `wl_pointer_gestures_v1` clients can be notified of these events.
2022-01-22cmd/swap: error on swapping a container with itselfRonan Pigott
2022-01-19tray: do not render passive itemsTobias Bengfort
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/#org.freedesktop.statusnotifieritem.status
2022-01-18build: execute wlroots subproject before finding depsSimon Ser
wlroots often requires dependencies more recent than Sway's. Executing the wlroots subproject first will give Meson a chance to find these newer dependencies, possibly via subprojects. The subproject will override the "wlroots" dependency when executed, so we don't need to use get_variable anymore. References: https://github.com/swaywm/sway/pull/6498#issuecomment-1001746017
2022-01-18transaction: destroying nodes aren't hiddenRouven Czerwinski
Commit 37d7bc69986f ("transaction: Only wait for ack from visible views") introduced a check which uses view_is_visible() to check if a view is still visible on the screen. However view_is_visible() will early return in case the node is in the destroying state. This is incorrect for transactions, since a destroying view which is visible will trigger configure events for other clients. This bug was visible when repeatedly opening and closing two views side by side, since we ignore the destroying node we get a frame where the still open view is shown with the old configure values and the rest is the desktop background. The next frame is than correct again. Fix this by considering destroying views as visible, we correctly wait for them and send the configure events to other views in time, fixing the background flicker. Fixes #6473
2022-01-18treat fullscreen windows as 'tiled' for commands/focusPatrick Hilhorst
2022-01-17input/cursor: treat swipe begin as idle activity tooTudor Brindus
Accidentally overlooked in fd53f80.
2022-01-17input/cursor: count pointer gestures as idle activityTudor Brindus
Fixes https://github.com/swaywm/sway/issues/6765.
2022-01-16commands/focus: drop trailing whitespaceSimon Ser
2022-01-13Upgrade for wlroots surface refactoringSimon Ser
See [1] for details. [1]: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3412
2022-01-12build: fix building with basuKirill Chibisov
02b412a introduced the use of list for sdbus deps, however it was assuming that all packages which were in a list has a version higher than 239. That is true for libsystemd and libelogind, since they use the same versions, however basu is using version numbers which are way lower than what libsystemd/libelogind are using, so basu only build is failing.
2022-01-12xdg-shell: use toplevel geometry to adjust the popup boxAleksei Bavshin
`popup_unconstrain` uses view coordinates to init the output box for popups. However wlroots expects the box to be set in a toplevel surface coordinate system, which is not always equal to view. The difference between those is a window geometry set via xdg-shell. GTK4 reserves some space for client-side decoration and thus has a window with top left corner not matching to (0, 0) of a surface. The box calculated without taking that into account was slightly shifted compared to the actual output and allowed to position part of the popup off screen.
2022-01-11Print deprecation notice when running SUIDKenny Levinsen
SUID privilege drop is needed for the "builtin"-backend of libseat, which copied our old "direct" backend behavior for the sake of compatibility and ease of transition. libseat now has a better alternative in the form of seatd-launch. It uses the normal seatd daemon and libseat backend and takes care of SUID for us. Add a soft deprecation warning to highlight our future intent of removing this code. The deprecation cycle is needed to avoid surprises when sway no longer drops privileges.
2022-01-11meson: check: false on run_commandKenny Levinsen
Future meson releases will change the default and warns when the implicit default is used, breaking builds. Explicitly set check: false to maintain behavior and silence warnings.
2022-01-09Add safety assert in parse_movement_unitSimon Ser
Let's add this just in case a caller passes argc == 0. References: https://github.com/swaywm/sway/issues/6737#issuecomment-1008082540
2022-01-08Destroy sub-surfaces with parent layer-shell surfaceSimon Ser
Closes: https://github.com/swaywm/sway/issues/6337
2022-01-09commands/move: Fix crash when pos_y is omittedDavid96
Fixes #6737
2022-01-07container: Fix crash when view unmaps + maps quicklyDavid Rosca
Followup on 4e4898e90f. If a view quickly maps and unmaps repeatedly, there will be multiple destroyed containers with same view in a single transaction. Each of these containers will then try to destroy this view, resulting in use after free. The container should only destroy the view if the view still belongs to the container. Simple reproducer: couple XMapWindow + XUnmapWindow in a loop followed by XDestroyWindow. See #6605
2022-01-07swaybar: fix tray item icon scaling, positioningNathan Schulte
2022-01-07swaybar: fix tray_padding vs min-height re: scaleNathan Schulte
Co-authored-by: xdavidwu <xdavidwuph@gmail.com>
2022-01-07input/seat: unset has_focus when focus_stack becomes emptyThomas Hebb
We currently track the focus of a seat in two ways: we use a list called focus_stack to track the order in which nodes have been focused, with the first node representing what's currently focused, and we use a variable called has_focus to indicate whether anything has focus--i.e. whether we should actually treat that first node as focused at any given time. In a number of places, we treat has_focus as implying that a focused node exists. If it's true, we attempt to dereference the return value of seat_get_focus(), our helper function for getting the first node in focus_list, with no further checks. But this isn't quite correct with the current implementation of seat_get_focus(): not only does it return NULL when has_focus is false, it also returns NULL when focus_stack contains no items. In most cases, focus_stack never becomes empty and so this doesn't matter at all. Since focus_stack stores a history of focused nodes, we rarely remove nodes from it. The exception to this is when a node itself goes away. In that case, we call seat_node_destroy() to remove it from focus_stack and free it. But we don't unset has_focus if we've removed the final node! This lets us get into a state where has_focus is true but seat_get_focus() returns NULL, leading to a segfault when we try to dereference it. Fix the issue both by updating has_focus in seat_node_destroy() and by adding an assertion in seat_get_focus() that ensures focus_stack and has_focus are in sync, which will make it easier to track down similar issues in the future. Fixes #6395. [1] There's some discussion in #1585 from when this was implemented about whether has_focus is actually necessary; it's possible we could remove it entirely, but for the moment this is the architecture we have.
2022-01-04[IPC] Add repeat delay/rate info to keyboardSeth Barberee
Closes #6735 wlroots already has the info in the struct so let's access it and print it out.
2021-12-23build: bump version to 1.8-devSimon Ser
Historically we've been sticking with the last release number in the master branch. However that's a bit confusing, people can't easily figure out whether they're using a release or a work-in-progress snapshot. Only the commit hash appended to the version number may help, but that's not very explicit and disappears when using a tarball. We could bump the version in master to the next release number. However during the RC cycle there would be a downgrade from 1.8 to 1.8-rc1. Also it would be hard to tell the difference between a stable release and an old snapshot. This patch introduces a new pre-release identifier, "dev". It's alphabetically before "rc" so it should be correctly sorted by semver comparisons. "dev" is upgraded to "rc" (and then to stable) when doing a release. The master branch always uses a "dev" version, only release branches use "rc" or stable versions.