| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Call view_set_tiled for mapping non-floating views
|
|
Fixes #2209.
|
|
Fix border weirdness
|
|
Fix use after free in transaction code
|
|
If we set an instruction as ready twice, it decreases the transaction's
num_waiting a second time and applies the transaction earlier than it
should. This no doubt has undesired effects, probably resulting in a use
after free.
Hopefully fixes the first part of #2207.
|
|
Fix #1857 -> transparency in swaylock
|
|
|
|
ipc-server: add display destroy listener
|
|
|
|
Otherwise it repeatedly sets the view's border to the config's default.
|
|
|
|
wl_event_source_remove() is illegal after display has been destroyed,
so just destroy everything when we still can.
==20392==ERROR: AddressSanitizer: heap-use-after-free on address 0x607000001240 at pc 0x00000048e86e bp 0x7ffe4b557e00 sp 0x7ffe4b557df0
READ of size 8 at 0x607000001240 thread T0
#0 0x48e86d in wl_list_insert ../common/list.c:149
#1 0x7fdf673d4d7d in wl_event_source_remove src/event-loop.c:487
#2 0x41b742 in ipc_terminate ../sway/ipc-server.c:94
#3 0x40b1ad in main ../sway/main.c:440
#4 0x7fdf6664c18a in __libc_start_main ../csu/libc-start.c:308
#5 0x409359 in _start (/opt/wayland/bin/sway+0x409359)
0x607000001240 is located 48 bytes inside of 72-byte region [0x607000001210,0x607000001258)
freed by thread T0 here:
#0 0x7fdf692c4880 in __interceptor_free (/lib64/libasan.so.5+0xee880)
#1 0x7fdf673d371a in wl_display_destroy src/wayland-server.c:1097
previously allocated by thread T0 here:
#0 0x7fdf692c4c48 in malloc (/lib64/libasan.so.5+0xeec48)
#1 0x7fdf673d4d9e in wl_event_loop_create src/event-loop.c:522
#2 0x40acb2 in main ../sway/main.c:363
#3 0x7fdf6664c18a in __libc_start_main ../csu/libc-start.c:308
|
|
Fix focus related damage
|
|
startup: move setenv WAYLAND_DISPLAY before config execs
|
|
When you have an unfocused container (so one view is focused_inactive),
and you focus any other view in that container, the view with
focused_inactive was not damaged. This is because we damaged the
previous focus and new focus, but needed to damage the parent of the new
focus.
|
|
We would previously run all config commands without the environment,
which would appear to work as our socket name is the default one, but
wayland clients would start up in the wrong sway session.
(This explains why 'sometimes' my swayidle processes wouldn't die with
sway, as they weren't listening to the correct socket)
|
|
|
|
Don't return pending children in seat_get_active_current_child
|
|
Fixes #2192.
seat_get_active_current_child is intended to return a child of the given
container which has finished its mapping transaction and is able to be
rendered on screen. The previous implementation was capable of returning
a pending child, which caused a child of a tabbed or stacked view to be
rendered prematurely while it was mapping.
|
|
Fix damage on swaybar when view requests to exit fullscreen
|
|
Fixes #2191
|
|
Idle inhibit
|
|
Static analysis fixes
|
|
|
|
|
|
|
|
|
|
Found through static analysis
|
|
Found through static analysis
|
|
If init fails halfway through it will call the destroy function,
which needs some coherent stuff filled.
Allocate with calloc and fill in what cannot fail first
Found through static analysis.
|
|
Found through static analysis.
|
|
Found through static analysis
|
|
Found through static analysis.
|
|
join_args is a freshly allocated string and can be used as is.
Found through static analysis.
|
|
Found through static analysis.
|
|
Found through static analysis.
|
|
Found through static analysis.
|
|
Pre-dividing 1000/60 would lose 2/3 due to round-up
Found through static analysis
|
|
The check didn't include && ws_num < 100 so l would always be 1 or 2
Instead of fixing logic it's simpler to just call snprintf twice to get
length and use that.
Also change malloc failure check to sway_assert because both callers of
this function do not do null check and would segfault...
Found through static analysis.
|
|
These could be called with NULL if there is no focus
Found through static analysis.
|
|
Found through static analysis.
|
|
policy is accessed again later
Found through static analysis
|
|
Found through static analysis.
|
|
Since ipc_send_reply frees the client on error, we need to check the
return value properly as we access client later on
Found through static analysis.
|
|
No logic change here, this one is mostly to please static analyzer:
- client->fd can never be -1 (and if it could, close() a few lines below
would have needed the same check)
- we never send permission denied error (dead code)
|
|
ipc_send_reply already does client disconnect on error, so we shouldn't
do it again.
We also need to process current index again as disconnect removes client
from the list we currently are processing (this is an indexed "list")
Found through static analysis.
|
|
size_t/ssize_t are 8 bytes on 64bit systems, so use the proper size to
transmit that information.
This could lead to ridiculously large alloc as len is not initialized to zero
Found through static analysis
|
|
With recent glibc the functions are strictly identical, but this might
not be true for all libc implementations
Found through static analysis.
|
|
Init screencopy manager
|
