aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-05Merge pull request #2582 from ascent12/funcDrew DeVault
Remove __PRETTY_FUNCTION__
2018-09-06Remove __PRETTY_FUNCTION__Scott Anderson
This is a non-standard extension as well as completely useless in C. __func__ is the standard way of doing this.
2018-09-05Merge pull request #2579 from RyanDwyer/adjust-container-boxDrew DeVault
Adjust container box
2018-09-05Merge pull request #2580 from RyanDwyer/fix-focus-after-fullscreenDrew DeVault
Restore focus correctly when closing a fullscreen view
2018-09-06Restore focus correctly when closing a fullscreen viewRyan Dwyer
We weren't calling seat_send_focus. I think this was previously called by seat_set_focus_warp.
2018-09-06Adjust container boxRyan Dwyer
Prior to f5b9815128b6c000bb5d47c339480fa481a5e99d, children of tabbed and stacked containers would have their container size and position set to the same as the tabbed/stacked container. Normally this would be a problem for a layout such as T[V[view]], but there was some code in the arrange functions which would check if the grandparent of the view was a tabbed or stacked container and would offset the view's Y accordingly. Commit f5b9815128b6c000bb5d47c339480fa481a5e99d changed the box to exclude the titlebar for all tabbed/stacked children so that the grandparent check could be removed. But this meant the title was not covered in the container and wasn't damaged when the child changed its title. This patch changes it so that a child of a tabbed/stacked container will have its box include the title bar if the child is a view, but not if it's a layout container. This fixes the title damage issue while avoiding the grandparent check in the arrange functions, and matches what we see visually.
2018-09-05Merge pull request #2572 from RedSoxFan/wlr-output-disablingDrew DeVault
Call wlr_output_enable on enable/disable if needed
2018-09-05Call wlr_output_enable on enable/disable if neededBrian Ashworth
2018-09-05Merge pull request #2540 from RyanDwyer/typesafetyDrew DeVault
Implement type safe arguments and demote sway_container
2018-09-05Merge pull request #2574 from ammgws/block-bg-fixemersion
Fix swaybar block background fill logic
2018-09-05Fix swaybar block background fill logicJason
Same as #2571 but for 1.0.
2018-09-05Allow marked containers to be moved out of the scratchpad via move commandRyan Dwyer
2018-09-05Fix inversed condition in criteriaRyan Dwyer
2018-09-05Fix clicking workspace buttonsRyan Dwyer
Because node_at_coords was returning the workspace's node, it interpreted this as clicking the focused workspace which was a no op.
2018-09-05Fix crash when view in scratchpad becomes urgentRyan Dwyer
2018-09-05Focus empty workspace when clicking itRyan Dwyer
Also removes container_at_coords as this function is no longer necessary.
2018-09-05Fix crash when running layout toggle splitRyan Dwyer
2018-09-05Fix floating view moving to 0,0 when splittingRyan Dwyer
2018-09-05Fix crash when using focus parent/child from an empty workspaceRyan Dwyer
2018-09-05Fix scratchpad related crashesRyan Dwyer
* Was crashing when a view was moved to the scratchpad (prev focus had no parent). * Was crashing when a hidden scratchpad view unmaps because it has no workspace.
2018-09-05Fix output position issueRyan Dwyer
Looks like the output dimensions need to be set when arranging rather than when a mode is set. Fixes an issue with position of fullscreen views.
2018-09-05Fix another focus bug when moving into outputRyan Dwyer
Find the focused_inactive view rather than possibly selecting a parent.
2018-09-05Fix focus bugRyan Dwyer
When changing focus from a view in one workspace to an empty workspace using `focus <direction>`, the view in the previous workspace would keep focused styling. This is because the check to unfocus it was only done in the container case and not workspace case, so it's been moved out of both.
2018-09-05Fix swaybars with no defined outputRyan Dwyer
2018-09-05Fix crash when moving mouse over a fullscreen split containerRyan Dwyer
2018-09-05Fix moving workspace to outputRyan Dwyer
2018-09-05Update output propertes on mode changeRyan Dwyer
This was previously done when arranging the output, but only needs to be done on mode change.
2018-09-05Fix mouse_warpingRyan Dwyer
2018-09-05Apply default config to outputRyan Dwyer
When starting without any output config, the default config was not applying.
2018-09-05Remove offset argument to container_add_siblingRyan Dwyer
I added this thinking that it might come in useful. Turns out it didn't.
2018-09-05Fix crash when focus hits edge of rootRyan Dwyer
2018-09-05Don't use wlr_output propertiesRyan Dwyer
These properties are before rotation.
2018-09-05Implement type safe arguments and demote sway_containerRyan Dwyer
This commit changes the meaning of sway_container so that it only refers to layout containers and view containers. Workspaces, outputs and the root are no longer known as containers. Instead, root, outputs, workspaces and containers are all a type of node, and containers come in two types: layout containers and view containers. In addition to the above, this implements type safe variables. This means we use specific types such as sway_output and sway_workspace instead of generic containers or nodes. However, it's worth noting that in a few places places (eg. seat focus and transactions) referring to them in a generic way is unavoidable which is why we still use nodes in some places. If you want a TL;DR, look at node.h, as well as the struct definitions for root, output, workspace and container. Note that sway_output now contains a workspaces list, and workspaces now contain a tiling and floating list, and containers now contain a pointer back to the workspace. There are now functions for seat_get_focused_workspace and seat_get_focused_container. The latter will return NULL if a workspace itself is focused. Most other seat functions like seat_get_focus and seat_set_focus now accept and return nodes. In the config->handler_context struct, current_container has been replaced with three pointers: node, container and workspace. node is the same as what current_container was, while workspace is the workspace that the node resides on and container is the actual container, which may be NULL if a workspace itself is focused. The global root_container variable has been replaced with one simply called root, which is a pointer to the sway_root instance. The way outputs are created, enabled, disabled and destroyed has changed. Previously we'd wrap the sway_output in a container when it is enabled, but as we don't have containers any more it needs a different approach. The output_create and output_destroy functions previously created/destroyed the container, but now they create/destroy the sway_output. There is a new function output_disable to disable an output without destroying it. Containers have a new view property. If this is populated then the container is a view container, otherwise it's a layout container. Like before, this property is immutable for the life of the container. Containers have both a `sway_container *parent` and `sway_workspace *workspace`. As we use specific types now, parent cannot point to a workspace so it'll be NULL for containers which are direct children of the workspace. The workspace property is set for all containers, except those which are hidden in the scratchpad as they have no workspace. In some cases we need to refer to workspaces in a container-like way. For example, workspaces have layout and children, but when using specific types this makes it difficult. Likewise, it's difficult for a container to get its parent's layout when the parent could be another container or a workspace. To make it easier, some helper functions have been created: container_parent_layout and container_get_siblings. container_remove_child has been renamed to container_detach and container_replace_child has been renamed to container_replace. `container_handle_fullscreen_reparent(con, old_parent)` has had the old_parent removed. We now unfullscreen the workspace when detaching the container, so this function is simplified and only needs one argument now. container_notify_subtree_changed has been renamed to container_update_representation. This is more descriptive of its purpose. I also wanted to be able to call it with whatever container was changed rather than the container's parent, which makes bubbling up to the workspace easier. There are now state structs per node thing. ie. sway_output_state, sway_workspace_state and sway_container_state. The focus, move and layout commands have been completely refactored to work with the specific types. I considered making these a separate PR, but I'd be backporting my changes only to replace them again, and it's easier just to test everything at once.
2018-09-04Merge pull request #2569 from RyanDwyer/deny-reload-repeatDrew DeVault
Deny repeating reload by holding key
2018-09-04Deny repeating reload by holding keyRyan Dwyer
Fixes #2568 The binding that gets stored in the keyboard's `repeat_binding` would get freed on reload, leaving a dangling pointer. Rather than attempt to unset the keyboard's `repeat_binding` along with the other bindings, I opted to just not set it for the reload command because there's no point in reloading repeatedly by holding the binding. This disables repeat bindings for the reload command. As we now need to detect whether it's a reload command in two places, I've added a binding flag to track whether it's a reload or not.
2018-09-03Merge pull request #2561 from RyanDwyer/window-role-criteriaDrew DeVault
Implement window_role criteria token
2018-09-04Implement window_role criteria tokenRyan Dwyer
Depends on https://github.com/swaywm/wlroots/pull/1226
2018-09-03Merge pull request #2564 from ppascher/masterDrew DeVault
Fix window_type with disabled xwayland support
2018-09-03Merge pull request #2542 from sghctoma/fix-freebsd-buildDrew DeVault
FreeBSD fixes
2018-09-03Merge pull request #2563 from taiyu-len/fix/misaligned-pointer-accessDrew DeVault
fix misaligned integer stores/loads
2018-09-03Merge pull request #2565 from ianyfan/fix-splashscreen-crashemersion
Fix crash when a splash screen opens on an empty workspace
2018-09-03Fix crash when a splash screen opens on an empty workspaceIan Fan
2018-09-03move criteria "instance", "class" and "window_role" inside HAVE_XWAYLAND ifdefs"Pascal Pascher
2018-09-03fix window_type with disabled xwayland supportPascal Pascher
2018-09-03Fixed window_type with disabled xwayland support.Pascal Pascher
2018-09-03Change _XOPEN_SOURCE defines to _POSIX_C_SOURCEsghctoma
2018-09-03Merge remote-tracking branch 'upstream/master' into fix-freebsd-buildsghctoma
2018-09-03Merge pull request #2553 from emersion/disabled-no-modesetBrian Ashworth
Do not modeset disabled outputs
2018-09-03Merge branch 'master' into disabled-no-modesetBrian Ashworth
2018-09-02prevent ub caused by misaligned stores/loadstaiyu