aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-20Combine output_by_name and output_by_identifierBrian Ashworth
This combines `output_by_name` and `output_by_identifier` into a single function called `output_by_name_or_id`. This allows for output identifiers to be used in all commands, simplifies the logic of the callers, and is more efficient since worst case is a single pass through the output list.
2018-12-19Terminate swaybg in output_disableBrian Ashworth
Moves the call to `terminate_swaybg` from inside `apply_output_config` to `output_disable`. The former was only called when an output was being disabled. The latter is called when an output is being disabled and when an output becomes disconnected. Without this, disconnecting an enabled output would result in a defunct swaybg process.
2018-12-18Return success when renaming a workspace to itselfRyan Dwyer
2018-12-17Merge pull request #3308 from RedSoxFan/fix-titlebar-clickDrew DeVault
Focus node before tiling drag if on titlebar
2018-12-17Focus node before tiling drag if on titlebarBrian Ashworth
Before attempting to drag a tiling container by its titlebar, focus it. This fixes clicking on titlebars to focus a container.
2018-12-17Merge pull request #3305 from emersion/isue-template-stack-traceBrian Ashworth
issue template: add instructions for stack traces
2018-12-17issue template: add instructions for stack tracesemersion
2018-12-17cmd_split: add null checks in do_splitBrian Ashworth
Fixes a crash when running `split` commands with the workspace focused.
2018-12-17Allow output ids and wildcard for workspace outputBrian Ashworth
This allows for output identifiers and to be used in the `workspace <workspace> output <outputs...>` command. Previously, only output names would be allowed. If an output identifier was given, it would never match an output. This also allows for the wildcard character (`*`) to be specified, which can be used to generate a list of workspace names that should be used when generating new workspaces
2018-12-17swaynag: remove double free of details buttonBrian Ashworth
If there are no arguments or invalid arguments given, swaynag will free `swaynag.details.button_details` under the `cleanup` label in main. It then called `swaynag_destroy`, which would attempt to free it again. Since `swaynag.details.button_details` is either freed on line 106 of main (when there is no detailed message) or added to `swaynag.buttons` on line 103 of main, there is no reason to manually free it in `swaynag_destroy`. Although I cannot reproduce a double free on my system, for some reason, it should have actually resulted in a double free in all code paths.
2018-12-17Allow tiling views to be dragged by the titlebarBrian Ashworth
Enables titling views to be dragged by the titlebar. This is in addition to using the modifier and dragging them from anywhere on the container surface. Floating views already allow this behavior.
2018-12-16Update for swaywm/wlroots#1377Rostislav Pehlivanov
-Werror is eͫ̐ͭ҉vi͆ͦ̏ͦlͥ̀͒̊͂͛
2018-12-15swaynag: damage the cursor surface on updateBrian Ashworth
When the cursor surface gets updated, it should be damaged. This also bumps up `wl_compositor` to version 4 to be able to use `wl_surface_damage_buffer`.
2018-12-15swaybar: fix cursor scaleBrian Ashworth
This fixes a few issues with swaybar's cursor scaling: 1. The cursor scale is now changed when the output scale changes 2. The cursor scale is no longer bound by the max output scale when swaybar is launched 3. Related to the previous item, the cursor is no longer tiny on low scale outputs after the max output scale has changed This also bumps up `wl_compositor` to version 4 to allow usage of `wl_surface_damage_buffer`.
2018-12-15Merge pull request #3291 from RedSoxFan/fix-focus-nonvisRyan Dwyer
Fix focusing on non-visible workspace
2018-12-14Fix focusing on non-visible workspaceBrian Ashworth
My previous attempt was not quite right. Changing the focus stack on a non-visible workspace should only be blocked if the focus would be set to the workspace itself
2018-12-13Rework default output configsBrian Ashworth
Default output configs were generated on reload to reset an output to its default settings. The idea was that anything that was removed from the config or changed at runtime and not in the config should be reset on reload. Originally, they were created using the output name. Recently, they were changed to use the output identifier. It turns out that there are issues of shadowing with that solution as well. This should fix those issues. Instead of generating the default output configs on reload and storing them in the output config list to merge on top of, they are now only generated when retrieving the output config for an output during a reload. This means that the default output configs are never stored anywhere and just used as a base to merge unaltered user configs on top of during a reload. Starting with a blank output config, merges get applied in the following order: 1. Default output config (only during a reload) 2. Wildcard config (only if neither output name or output identifier exist) 3. Output name config 4. Output identifier config
2018-12-12Fix criteria execution in view_mapmwenzkowski
This patch moves view_execute_criteria(view) below the fullscreen code. Previously, if a view requested to be started in fullscreen, this was done after execution of criteria and hence it was impossible to disable fullscreen via criteria. Fixes #3285
2018-12-12swaybar: fix sep block width for mixed scalesBrian Ashworth
When there are outputs with mixed scales, it was possible for swaybar to alter `block->separator_block_width` for an output with a higher scale, and use the changed value for a lower scale output. This caused there to be larger than normal separation between blocks on the lower scale outputs. The issue is more obvious the larger the scale difference between the highest scale output and the lowest scale output. This fixes the issue by using a local variable that is originally set to `block->separator_block_width` for rendering, but if it needs to be increased, the local variable is the only thing touched.
2018-12-12swaybar: handle block->urgentBrian Ashworth
When `block->urgent` is set, use the urgent colors. This matches i3bar's behavior. Previously, swaybar just ignored the property. This also adds in rendering for right borders, which was missing.
2018-12-12Keep focus when destroying containers on nonvis wsBrian Ashworth
Changing the focus stack when destroying a container's node on a non-visible workspace (on an non-focused output) incorrectly causes the non-visible workspace to become visible. If the workspace is empty, it will not be destroyed since it is now visible. Additionally since there was no workspace::focus event, swaybar still shows the previous workspace as focus-inactive. It also makes no sense to change visible workspaces due to a container on a non-visible workspace being destroyed. Since the focus will either be set when switching to the non-visible workspace or the workspace will be destroyed due to being empty, there is no need to change the focus stack when destroying a container on a non-visible workspace.
2018-12-10Call wlr_output_enable for disabled new outputsBrian Ashworth
When a new output is detected and it is disabled by the output config, call `wlr_output_enable(output->wlr_output, false)` to DPMS off the output.
2018-12-09Merge pull request #3271 from ianyfan/list-cleanupRyan Dwyer
list.c: Remove list_foreach
2018-12-08Merge pull request #3264 from ianyfan/resize-listBrian Ashworth
list: double list capacity when resizing instead of incrementing
2018-12-09list.c: rename free_flat_list to list_free_items_and_destroyIan Fan
2018-12-09Cleanup list codeIan Fan
2018-12-09list.c: Remove list_foreachIan Fan
Most occurrences have been replaced by `free_flat_list` which has been moved from stringop.c to list.c. The rest have been replaced by for loops.
2018-12-08Merge pull request #3260 from RedSoxFan/split-flattenRyan Dwyer
cmd_split: flatten when possible
2018-12-06list: double list capacity when resizing instead of incrementingIan Fan
This is the industry standard since it allows insertion to be amortized O(1) time.
2018-12-05cmd_split: flatten when possibleBrian Ashworth
2018-12-05Fix command list executionmwenzkowski
Determine the container/workspace a command is run on, each time when a command of the command list will be run. Previously the container/workspace was determined only once at the beginning of command list execution, which led to wrong behaviour because commands wouldn't take into account when a previous command changed the focused container.
2018-12-04Merge pull request #3252 from hvenev/swaybar-relBrian Ashworth
Add relative coordinates in JSON for i3bar click events
2018-12-04Add relative coordinates in JSON for i3bar click eventsHristo Venev
Compatibility with i3 commit 161db6f17d734ac9deb0a20e81b78d4b2a92ce68.
2018-12-03config: do not set $XDG_CONFIG_HOME if unset or emptyIan Fan
Instead redefine the config paths to use the default $HOME/.config
2018-12-03config: set $XDG_CONFIG_HOME if emptyIan Fan
Before, it was only set if it was not set, but it should also be done when empty.
2018-12-03Fix identifier output configs on reloadBrian Ashworth
When generating default output configs to reset the outputs to their default settings on reload, the output name was being used. Additionally when determining the output config to apply, if there was an output config with the output name, that was being used without checking for an identifier config. This caused sway to completely ignore the users specified output config. To fix this issue, the following changes have been made: 1. Default output configs as created for the identifier now instead of name. This actually makes more sense anyway since you could hotplug multiple different outputs to the same port. 2. In get_output_config, which is only used to determine which output config to apply, output configs for both the name and identifier are queried. If both are found, a new output config is generated with the identifier config merged on top of the name config. If just one is found, a copy of that config is returned. This change also requires that the result from get_output_config be freed after use to prevent memory leaks, which required some minor changes to logic in apply_output_config_to_outputs.
2018-12-03cmd_focus: show scratchpad if hiddenBrian Ashworth
If a scratchpad container is hidden, it is still focusable using criteria and should be shown. This fixes a segfault when attempting to rebase the cursor since previously the scratchpad container would not be on any output.
2018-12-02Merge pull request #3239 from ForTheReallys/bindsym-no-warnBrian Ashworth
Add option to bindsym/bindcode to suppress warning on override
2018-12-02Add option to bindsym/bindcode to suppress warning on overrideAlex Maese
2018-12-02fix typobschacht
tranform -> transform
2018-12-02fix typobschacht
bahavior -> behavior
2018-12-02Merge pull request #3227 from emersion/swap-buffers-damage-coordsDrew DeVault
Update for swaywm/wlroots#1403
2018-12-02Merge pull request #3228 from ianyfan/swayidleemersion
meson.build: remove obsolete definition of swayidle_deps
2018-12-01Merge pull request #3229 from mwenzkowski/fix-fullscreen-cmdBrian Ashworth
Fix fullscreen command and improve documentation
2018-12-01meson.build: remove obsolete definition of swayidle_depsIan Fan
2018-12-01Update for swaywm/wlroots#1403emersion
2018-12-01Merge pull request #3226 from CameronNemo/muslemersion
swaylock: fix build with musl libc
2018-11-30swaylock: fix build with musl libcCameron Nemo
Signed-off-by: Cameron Nemo <camerontnorman@gmail.com>
2018-11-30sway.5: Improve documentationmwenzkowski
Document the optional arguments of the fullscreen command.
2018-11-29Fix the error result of the fullscreen commandmwenzkowski
Changes the error result from CMD_INVALID to CMD_FAILURE, since CMD_INVALID indicates an unknown command or parser error and neither occurs where CMD_INVALID was used.