1 files changed, 31 insertions, 24 deletions

diff --git a/swaybar/bar.c b/swaybar/bar.c
index ab307fd4..388c24c4 100644
--- a/swaybar/bar.c
+++ b/swaybar/bar.c
@@ -16,12 +16,13 @@
 #else
 #include <linux/input-event-codes.h>
 #endif
-#include "swaybar/render.h"
+#include "swaybar/bar.h"
 #include "swaybar/config.h"
 #include "swaybar/event_loop.h"
-#include "swaybar/status_line.h"
-#include "swaybar/bar.h"
+#include "swaybar/i3bar.h"
 #include "swaybar/ipc.h"
+#include "swaybar/status_line.h"
+#include "swaybar/render.h"
 #include "ipc-client.h"
 #include "list.h"
 #include "log.h"
@@ -71,6 +72,16 @@ static void swaybar_output_free(struct swaybar_output *output) {
 	free(output);
 }
 
+static void set_output_dirty(struct swaybar_output *output) {
+	if (output->frame_scheduled) {
+		output->dirty = true;
+		return;
+	}
+	if (output->surface) {
+		render_frame(output);
+	}
+}
+
 static void layer_surface_configure(void *data,
 		struct zwlr_layer_surface_v1 *surface,
 		uint32_t serial, uint32_t width, uint32_t height) {
@@ -78,7 +89,7 @@ static void layer_surface_configure(void *data,
 	output->width = width;
 	output->height = height;
 	zwlr_layer_surface_v1_ack_configure(surface, serial);
-	render_frame(output->bar, output);
+	set_output_dirty(output);
 }
 
 static void layer_surface_closed(void *_output,
@@ -324,27 +335,22 @@ static void output_geometry(void *data, struct wl_output *wl_output, int32_t x,
 		const char *make, const char *model, int32_t transform) {
 	struct swaybar_output *output = data;
 	output->subpixel = subpixel;
-	if (output->surface) {
-		render_frame(output->bar, output);
-	}
 }
 
-static void output_mode(void *data, struct wl_output *output, uint32_t flags,
+static void output_mode(void *data, struct wl_output *wl_output, uint32_t flags,
 		int32_t width, int32_t height, int32_t refresh) {
 	// Who cares
 }
 
-static void output_done(void *data, struct wl_output *output) {
-	// Who cares
+static void output_done(void *data, struct wl_output *wl_output) {
+	struct swaybar_output *output = data;
+	set_output_dirty(output);
 }
 
 static void output_scale(void *data, struct wl_output *wl_output,
 		int32_t factor) {
 	struct swaybar_output *output = data;
 	output->scale = factor;
-	if (output->surface) {
-		render_frame(output->bar, output);
-	}
 }
 
 struct wl_output_listener output_listener = {
@@ -380,7 +386,7 @@ static void xdg_output_handle_done(void *data,
 		wl_list_insert(&bar->outputs, &output->link);
 
 		add_layer_surface(output);
-		render_frame(bar, output);
+		set_output_dirty(output);
 	}
 }
 
@@ -469,23 +475,23 @@ static const struct wl_registry_listener registry_listener = {
 	.global_remove = handle_global_remove,
 };
 
-static void render_all_frames(struct swaybar *bar) {
+static void set_bar_dirty(struct swaybar *bar) {
 	struct swaybar_output *output;
 	wl_list_for_each(output, &bar->outputs, link) {
-		if (output->surface != NULL) {
-			render_frame(bar, output);
-		}
+		set_output_dirty(output);
 	}
 }
 
-void bar_setup(struct swaybar *bar,
+bool bar_setup(struct swaybar *bar,
 		const char *socket_path, const char *bar_id) {
 	bar_init(bar);
 	init_event_loop();
 
 	bar->ipc_socketfd = ipc_open_socket(socket_path);
 	bar->ipc_event_socketfd = ipc_open_socket(socket_path);
-	ipc_initialize(bar, bar_id);
+	if (!ipc_initialize(bar, bar_id)) {
+		return false;
+	}
 	if (bar->config->status_command) {
 		bar->status = status_line_init(bar->config->status_command);
 	}
@@ -525,7 +531,8 @@ void bar_setup(struct swaybar *bar,
 	assert(pointer->cursor_surface);
 
 	ipc_get_workspaces(bar);
-	render_all_frames(bar);
+	set_bar_dirty(bar);
+	return true;
 }
 
 static void display_in(int fd, short mask, void *data) {
@@ -539,7 +546,7 @@ static void display_in(int fd, short mask, void *data) {
 static void ipc_in(int fd, short mask, void *data) {
 	struct swaybar *bar = data;
 	if (handle_ipc_readable(bar)) {
-		render_all_frames(bar);
+		set_bar_dirty(bar);
 	}
 }
 
@@ -547,10 +554,10 @@ static void status_in(int fd, short mask, void *data) {
 	struct swaybar *bar = data;
 	if (mask & (POLLHUP | POLLERR)) {
 		status_error(bar->status, "[error reading from status command]");
-		render_all_frames(bar);
+		set_bar_dirty(bar);
 		remove_event(fd);
 	} else if (status_handle_readable(bar->status)) {
-		render_all_frames(bar);
+		set_bar_dirty(bar);
 	}
 }