5 files changed, 70 insertions, 7 deletions
diff --git a/sway/commands/bar.c b/sway/commands/bar.c
index f9ed530e..0cf94907 100644
--- a/sway/commands/bar.c
+++ b/sway/commands/bar.c
@@ -14,6 +14,7 @@ static struct cmd_handler bar_handlers[] = {
 	{ "colors", bar_cmd_colors },
 	{ "context_button", bar_cmd_context_button },
 	{ "font", bar_cmd_font },
+	{ "gaps", bar_cmd_gaps },
 	{ "height", bar_cmd_height },
 	{ "hidden_state", bar_cmd_hidden_state },
 	{ "icon_theme", bar_cmd_icon_theme },
diff --git a/sway/commands/bar/gaps.c b/sway/commands/bar/gaps.c
new file mode 100644
index 00000000..f78f3742
--- /dev/null
+++ b/sway/commands/bar/gaps.c
@@ -0,0 +1,60 @@
+#include <stdlib.h>
+#include <string.h>
+#include <strings.h>
+#include "sway/commands.h"
+#include "sway/ipc-server.h"
+#include "log.h"
+
+struct cmd_results *bar_cmd_gaps(int argc, char **argv) {
+	struct cmd_results *error = NULL;
+	if ((error = checkarg(argc, "gaps", EXPECTED_AT_LEAST, 1))) {
+		return error;
+	}
+	if ((error = checkarg(argc, "gaps", EXPECTED_AT_MOST, 4))) {
+		return error;
+	}
+	if (!config->current_bar) {
+		return cmd_results_new(CMD_FAILURE, "bar gaps", "No bar defined.");
+	}
+
+	int top = 0, right = 0, bottom = 0, left = 0;
+
+	for (int i = 0; i < argc; i++) {
+		char *end;
+		int amount = strtol(argv[i], &end, 10);
+		if (strlen(end) && strcasecmp(end, "px") != 0) {
+			return cmd_results_new(CMD_INVALID, "bar gaps",
+					"Expected 'bar [<bar-id>] gaps <all> | <horizonal> "
+					"<vertical> | <top> <right> <bottom> <left>'");
+		}
+
+		if (i == 0) {
+			top = amount;
+		}
+		if (i == 0 || i == 1) {
+			right = amount;
+		}
+		if (i == 0 || i == 2) {
+			bottom = amount;
+		}
+		if (i == 0 || i == 1 || i == 3) {
+			left = amount;
+		}
+	}
+
+	config->current_bar->gaps.top = top;
+	config->current_bar->gaps.right = right;
+	config->current_bar->gaps.bottom = bottom;
+	config->current_bar->gaps.left = left;
+
+	wlr_log(WLR_DEBUG, "Setting bar gaps to %d %d %d %d on bar: %s",
+			config->current_bar->gaps.top, config->current_bar->gaps.right,
+			config->current_bar->gaps.bottom, config->current_bar->gaps.left,
+			config->current_bar->id);
+
+	if (!config->reading) {
+		ipc_event_barconfig_update(config->current_bar);
+	}
+
+	return cmd_results_new(CMD_SUCCESS, NULL, NULL);
+}
diff --git a/sway/commands/bind.c b/sway/commands/bind.c
index 34881b0f..9112815f 100644
--- a/sway/commands/bind.c
+++ b/sway/commands/bind.c
@@ -255,8 +255,12 @@ static struct cmd_results *cmd_bindsym_or_bindcode(int argc, char **argv,
 	for (int i = 0; i < mode_bindings->length; ++i) {
 		struct sway_binding *config_binding = mode_bindings->items[i];
 		if (binding_key_compare(binding, config_binding)) {
-			wlr_log(WLR_DEBUG, "overwriting old binding with command '%s'",
-				config_binding->command);
+			wlr_log(WLR_INFO, "Overwriting binding '%s' for device '%s' "
+					"from `%s` to `%s`", argv[0], binding->input,
+					binding->command, config_binding->command);
+			config_add_swaynag_warning("Overwriting binding '%s' for device "
+					"'%s' to `%s` from `%s`", argv[0], binding->input,
+					binding->command, config_binding->command);
 			free_sway_binding(config_binding);
 			mode_bindings->items[i] = binding;
 			overwritten = true;
diff --git a/sway/commands/move.c b/sway/commands/move.c
index 240b9f04..4dc547db 100644
--- a/sway/commands/move.c
+++ b/sway/commands/move.c
@@ -216,6 +216,7 @@ static void container_move_to_container(struct sway_container *container,
 		return;
 	}
 	if (container_is_floating(container)) {
+		container_move_to_workspace(container, destination->workspace);
 		return;
 	}
 	struct sway_workspace *old_workspace = container->workspace;
diff --git a/sway/commands/output/background.c b/sway/commands/output/background.c
index 30fb47c4..2cd1b76a 100644
--- a/sway/commands/output/background.c
+++ b/sway/commands/output/background.c
@@ -116,11 +116,8 @@ struct cmd_results *output_cmd_background(int argc, char **argv) {
 		if (!can_access) {
 			wlr_log(WLR_ERROR, "Unable to access background file '%s': %s",
 					src, strerror(errno));
-			if (config->reading && !config->validating) {
-				swaynag_log(config->swaynag_command,
-						&config->swaynag_config_errors,
-						"Unable to access background file '%s'", src);
-			}
+			config_add_swaynag_warning("Unable to access background file '%s'",
+					src);
 			free(src);
 		} else {
 			// Escape double quotes in the final path for swaybg