Merge pull request #1276 from 4e554c4c/bad_items

Don't trust SNI names, fixes #1274

1 files changed, 6 insertions, 0 deletions

diff --git a/swaybar/tray/sni.c b/swaybar/tray/sni.c
index 0c46d5c0..d9a5ca80 100644
--- a/swaybar/tray/sni.c
+++ b/swaybar/tray/sni.c
@@ -413,6 +413,12 @@ static void get_unique_name(struct StatusNotifierItem *item) {
 }
 
 struct StatusNotifierItem *sni_create(const char *name) {
+	// Make sure `name` is well formed
+	if (!dbus_validate_bus_name(name, NULL)) {
+		sway_log(L_INFO, "Name (%s) is not a bus name. We cannot create an item.", name);
+		return NULL;
+	}
+
 	struct StatusNotifierItem *item = malloc(sizeof(struct StatusNotifierItem));
 	item->name = strdup(name);
 	item->unique_name = NULL;