diff options
| author | Tudor Brindus <me@tbrindus.ca> | 2020-10-18 15:55:52 -0400 |
|---|---|---|
| committer | Simon Ser <contact@emersion.fr> | 2020-10-18 22:12:16 +0200 |
| commit | 5bd6a5ce3ff3cb879463646d4f88745420335b23 (patch) | |
| tree | e5d4e086b744051d6ba1b2f8d5e1652449c01b43 /sway | |
| parent | 33affb33d2d083b6ab8500175210370141e0a113 (diff) | |
transaction: don't reconfigure X views unless integral coords changed
Sway logical coordinates are doubles, but they get truncated to integers
when sent to Xwayland through `xcb_configure_window`. X11 apps will not
respond to duplicate configure requests (from their truncated point of
view) and cause transactions to time out.
Fixes #5035.
Diffstat (limited to 'sway')
| -rw-r--r-- | sway/desktop/transaction.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/sway/desktop/transaction.c b/sway/desktop/transaction.c index 2b268e2c..0d0e0635 100644 --- a/sway/desktop/transaction.c +++ b/sway/desktop/transaction.c @@ -397,8 +397,12 @@ static bool should_configure(struct sway_node *node, // Xwayland views are position-aware and need to be reconfigured // when their position changes. if (node->sway_container->view->type == SWAY_VIEW_XWAYLAND) { - if (cstate->content_x != istate->content_x || - cstate->content_y != istate->content_y) { + // Sway logical coordinates are doubles, but they get truncated to + // integers when sent to Xwayland through `xcb_configure_window`. + // X11 apps will not respond to duplicate configure requests (from their + // truncated point of view) and cause transactions to time out. + if ((int)cstate->content_x != (int)istate->content_x || + (int)cstate->content_y != (int)istate->content_y) { return true; } } |