aboutsummaryrefslogtreecommitdiff
path: root/sway
diff options
context:
space:
mode:
authorRyan Dwyer <ryandwyer1@gmail.com>2018-06-23 17:47:28 +1000
committerRyan Dwyer <ryandwyer1@gmail.com>2018-06-23 17:47:28 +1000
commit32b865e610dd937af17ce36b8c986e41f55a4627 (patch)
treebb89819988dcebe0d621c645fac35c9bfe4198d4 /sway
parentb11c9199a61775d7ed441c68238e11e93fbd6d21 (diff)
Fix crash when deleting last child in a tabbed or stacked container
There was no `current` child because the container was destroyed. This makes it fall back to looking in the parent's current children list.
Diffstat (limited to 'sway')
-rw-r--r--sway/desktop/output.c28
-rw-r--r--sway/input/seat.c12
2 files changed, 28 insertions, 12 deletions
diff --git a/sway/desktop/output.c b/sway/desktop/output.c
index 9db95ef5..1ca48975 100644
--- a/sway/desktop/output.c
+++ b/sway/desktop/output.c
@@ -713,7 +713,7 @@ static void render_container_tabbed(struct sway_output *output,
}
struct sway_seat *seat = input_manager_current_seat(input_manager);
struct sway_container *focus = seat_get_focus(seat);
- struct sway_container *current = seat_get_active_child(seat, con);
+ struct sway_container *current = seat_get_active_current_child(seat, con);
struct border_colors *current_colors = NULL;
struct sway_container_state *pstate = &con->current;
@@ -756,11 +756,13 @@ static void render_container_tabbed(struct sway_output *output,
}
// Render surface and left/right/bottom borders
- if (current->type == C_VIEW) {
- render_view(output, damage, current, current_colors);
- } else {
- render_container(output, damage, current,
- parent_focused || current == focus);
+ if (current) {
+ if (current->type == C_VIEW) {
+ render_view(output, damage, current, current_colors);
+ } else {
+ render_container(output, damage, current,
+ parent_focused || current == focus);
+ }
}
}
@@ -775,7 +777,7 @@ static void render_container_stacked(struct sway_output *output,
}
struct sway_seat *seat = input_manager_current_seat(input_manager);
struct sway_container *focus = seat_get_focus(seat);
- struct sway_container *current = seat_get_active_child(seat, con);
+ struct sway_container *current = seat_get_active_current_child(seat, con);
struct border_colors *current_colors = NULL;
struct sway_container_state *pstate = &con->current;
@@ -812,11 +814,13 @@ static void render_container_stacked(struct sway_output *output,
}
// Render surface and left/right/bottom borders
- if (current->type == C_VIEW) {
- render_view(output, damage, current, current_colors);
- } else {
- render_container(output, damage, current,
- parent_focused || current == focus);
+ if (current) {
+ if (current->type == C_VIEW) {
+ render_view(output, damage, current, current_colors);
+ } else {
+ render_container(output, damage, current,
+ parent_focused || current == focus);
+ }
}
}
diff --git a/sway/input/seat.c b/sway/input/seat.c
index 1ea36466..436d18e2 100644
--- a/sway/input/seat.c
+++ b/sway/input/seat.c
@@ -829,6 +829,18 @@ struct sway_container *seat_get_active_child(struct sway_seat *seat,
return NULL;
}
+struct sway_container *seat_get_active_current_child(struct sway_seat *seat,
+ struct sway_container *container) {
+ struct sway_container *child = seat_get_active_child(seat, container);
+ if (child) {
+ return child;
+ }
+ if (container->current.children->length == 1) {
+ return container->current.children->items[0];
+ }
+ return NULL;
+}
+
struct sway_container *seat_get_focus(struct sway_seat *seat) {
if (!seat->has_focus) {
return NULL;