diff options
| author | Aleksei Bavshin <alebastr89@gmail.com> | 2023-12-26 22:26:02 -0800 |
|---|---|---|
| committer | Ronan Pigott <ronan@rjp.ie> | 2024-02-17 00:54:30 -0700 |
| commit | d19810eba8959f052d91fd6609cef6adf36b3951 (patch) | |
| tree | 90b727f8cb792b06bf9aa1cc527d254c6c23edbf /sway/xdg_activation_v1.c | |
| parent | f6d22f8e6886edfeca3ecbb695b02079e81ce360 (diff) | |
xdg-activation: distinguish activation and urgency requests
Check if the app that requested a token has provided a valid input
serial and a focused surface. Downgrade activation request to urgency
otherwise.
This is mostly in line with what other Wayland compositors decided to
do, and offers a better security than the original logic.
Diffstat (limited to 'sway/xdg_activation_v1.c')
| -rw-r--r-- | sway/xdg_activation_v1.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sway/xdg_activation_v1.c b/sway/xdg_activation_v1.c index 72c7fa4c..b7c80dd4 100644 --- a/sway/xdg_activation_v1.c +++ b/sway/xdg_activation_v1.c @@ -44,8 +44,11 @@ void xdg_activation_v1_handle_request_activate(struct wl_listener *listener, seat = ctx->token->seat ? ctx->token->seat->data : NULL; } - if (seat) { + if (seat && ctx->had_focused_surface) { view_request_activate(view, seat); + } else { + // The token is valid, but cannot be used to activate a window + view_request_urgent(view); } } |