diff options
author | Jarkko Oranen <oranenj@iki.fi> | 2017-03-19 16:46:27 +0200 |
---|---|---|
committer | Jarkko Oranen <oranenj@iki.fi> | 2017-03-19 16:58:39 +0200 |
commit | 924ed6464c25219bc0dd5ed06885cd3692042a20 (patch) | |
tree | 7be02709fd7d81d1829810df24578faa73f77804 /sway/commands/input | |
parent | d7350915d9d9d8aba936c6139aa085804548f6b1 (diff) |
Prevent "move next" and "move prev" commands from crashing
Fixes #1120
When the parent of a view is C_WORKSPACE and the movement direction
is either MOVE_PREV or MOVE_NEXT, the code would attempt to move the
views to the next output, but swayc_adjacent_output can't accept
non-directional movement commands and causes undefined behaviour and
a segfault.
If the code is simply skipped, we end up in an infinite loop.
Instead, we can allow containers whose parent is a C_WORKSPACE take the
path that handles MOVE_PREV and MOVE_NEXT, which behaves as you would
expect.
I'm not certain that this fix is entirely correct as the desired behaviour
of move_container is not very well defined, but it seems to work.
Diffstat (limited to 'sway/commands/input')
0 files changed, 0 insertions, 0 deletions