aboutsummaryrefslogtreecommitdiff
path: root/include/sway/desktop/transaction.h
diff options
context:
space:
mode:
authorRyan Dwyer <ryandwyer1@gmail.com>2018-08-02 20:54:03 +1000
committerRyan Dwyer <ryandwyer1@gmail.com>2018-08-02 20:54:03 +1000
commit8314019f660cd28fc8cdb634f82b437105074258 (patch)
treed788e6fc6cc5855cc2ffea909ddb22fb8b9f37ea /include/sway/desktop/transaction.h
parentd6095588a143710d25be47577ea65517770e7a74 (diff)
Fix race condition crashes when unmapping views
This fixes two issues which were both introduced in #2396. First issue: The PR changes the location of the buffer save to transaction_apply, but puts it inside the should_configure block. For unmapping (destroying) views, should_configure returns false so it wasn't saving the buffer. If a frame was rendered between the unmap and the transaction applying then it would result in a crash. Second issue: If a destroying view is involved in two transactions, we must not release the buffer between the transactions because there is no live buffer to grab any more.
Diffstat (limited to 'include/sway/desktop/transaction.h')
0 files changed, 0 insertions, 0 deletions