diff options
author | Manuel Mendez <mmendez534@gmail.com> | 2019-11-17 10:50:26 -0500 |
---|---|---|
committer | Simon Ser <contact@emersion.fr> | 2019-11-17 17:18:54 +0100 |
commit | 8ffa3cf43906fa95c127c01b751590e77c7bf695 (patch) | |
tree | 3463efce4786c8cdce92a1e17acbad151346e36d /contrib/_incr_version | |
parent | 7f54495b5e62a65627cdb61f099e241f0594a6d9 (diff) |
grimshot: fix branching on command exit status
The previous behavior was incorrect because `if` was checking the return
status of the `[` command which was never going to be an error. `[`
seems to only return an error if no args are provided. This was
basically a useless use of `[` anyway since it was just meant as a
straight interpretation of command exit, something that `if` can do
itself.
Compare:
```sh
[ ]; echo ?=$?
[ /bin/false ]; echo ?=$?
if [ /bin/false ]; then echo this is the unintended bug; fi
if /bin/false; then echo this will not be printed; fi
```
Diffstat (limited to 'contrib/_incr_version')
0 files changed, 0 insertions, 0 deletions