aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Ashworth <bosrsf04@gmail.com>2018-12-17 00:54:00 -0500
committeremersion <contact@emersion.fr>2018-12-17 09:21:14 +0100
commiteb527ac01ad7e3255b757d620bc678a834a3958a (patch)
treea6b7eeb10108ec5b23aebbf9e43bf72e74fdefcb
parent8d7ebc258a830dc893bef327c2e672a901ced4ed (diff)
swaynag: remove double free of details button
If there are no arguments or invalid arguments given, swaynag will free `swaynag.details.button_details` under the `cleanup` label in main. It then called `swaynag_destroy`, which would attempt to free it again. Since `swaynag.details.button_details` is either freed on line 106 of main (when there is no detailed message) or added to `swaynag.buttons` on line 103 of main, there is no reason to manually free it in `swaynag_destroy`. Although I cannot reproduce a double free on my system, for some reason, it should have actually resulted in a double free in all code paths.
-rw-r--r--swaynag/swaynag.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/swaynag/swaynag.c b/swaynag/swaynag.c
index 2fc2416f..674c24b5 100644
--- a/swaynag/swaynag.c
+++ b/swaynag/swaynag.c
@@ -416,7 +416,6 @@ void swaynag_destroy(struct swaynag *swaynag) {
free(button);
}
list_free(swaynag->buttons);
- free(swaynag->details.button_details);
free(swaynag->details.message);
free(swaynag->details.button_up.text);
free(swaynag->details.button_down.text);