aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRyan Dwyer <ryandwyer1@gmail.com>2018-06-26 20:18:57 +1000
committerRyan Dwyer <ryandwyer1@gmail.com>2018-06-26 20:18:57 +1000
commita7b3f29292cad029f010aa8b5fafb56b08ba4ed7 (patch)
tree7f70df64d1ec140d5d1bf744dd4a2c087e0564e7
parent93696b78ecbc31ec34be97ec26836efb74d359f0 (diff)
Remove incorrect assertion and supporting code
Children can exist when destroying a container, such as when destroying the last output. Sway is not terminating in that case.
-rw-r--r--include/sway/server.h2
-rw-r--r--sway/main.c1
-rw-r--r--sway/tree/container.c9
3 files changed, 0 insertions, 12 deletions
diff --git a/include/sway/server.h b/include/sway/server.h
index 94e8f2a2..bd96b085 100644
--- a/include/sway/server.h
+++ b/include/sway/server.h
@@ -47,8 +47,6 @@ struct sway_server {
bool debug_txn_timings;
- bool terminating;
-
struct sway_transaction *head_transaction; // singly linked list
// When a view is being destroyed and is waiting for a transaction to
diff --git a/sway/main.c b/sway/main.c
index 61ae6a5f..a325dc3a 100644
--- a/sway/main.c
+++ b/sway/main.c
@@ -34,7 +34,6 @@ struct sway_server server;
void sway_terminate(int exit_code) {
terminate_request = true;
exit_value = exit_code;
- server.terminating = true;
wl_display_terminate(server.wl_display);
}
diff --git a/sway/tree/container.c b/sway/tree/container.c
index 0c860405..2b9eb636 100644
--- a/sway/tree/container.c
+++ b/sway/tree/container.c
@@ -319,15 +319,6 @@ struct sway_container *container_destroy_noreaping(struct sway_container *con) {
}
}
- // At this point the container being destroyed shouldn't have any children
- // unless sway is terminating.
- if (!server.terminating) {
- if (!sway_assert(!con->children || con->children->length == 0,
- "Didn't expect to see children here")) {
- return NULL;
- }
- }
-
con->destroying = true;
list_add(server.destroying_containers, con);