fork of seatd https://git.vlhl.dev/navi/seatd.git/atom?h=master 2022-05-23T20:03:38+00:00 2022-05-23T20:03:38+00:00 Kenny Levinsen kl@kl.wtf 2022-05-23T20:03:38+00:00 urn:sha1:a803ba0502cccf147eec7fbcacd11c5b8643c0e0 2022-02-26T21:25:27+00:00 Kenny Levinsen kl@kl.wtf 2022-02-26T19:25:22+00:00 urn:sha1:0d6bdf4f01e5be10c29dd786f2531b96e1d935cd Configurable socket paths exist mainly to facilitate multiple parallel seatd instances. However, the only valid use-case for running multiple instances of seatd is testing during development, which can just as well be done by changing SEATD_DEFAULTPATH at compile-time for test builds. Remove the command-line argument in seatd for runtime configuration of socket path, hardcode the socket path in seatd-launch, and change seatd unlink/chmod/chown code to not run when started by seatd-launch. This means that seatd-launch will now fail to start seatd if another seatd instance is already running. The unlink code still runs when seatd is started normally to assist in system crash recovery, but this may be removed later if we deem it unnecessary. 2022-02-26T18:17:26+00:00 Kenny Levinsen kl@kl.wtf 2022-02-26T18:05:49+00:00 urn:sha1:9bbdf0f0b8d383edd1d621507c04db0a5382a5af SEATD_LOGLEVEL was used to set the loglevel despite already having getopt in place. Remove the environment variable and make a command-line argument for it instead. 2022-02-21T20:33:06+00:00 Kenny Levinsen kl@kl.wtf 2022-02-21T20:33:06+00:00 urn:sha1:3eb0db57bb1c23b5157279223f248d58d9662aae 2022-02-21T20:27:14+00:00 Kenny Levinsen kl@kl.wtf 2022-02-21T20:27:14+00:00 urn:sha1:ed90ed62cdf1c4e7d59e4d279a5bf946b93057dd We also reduce the size of the buffer from 256 bytes to a much more reasonable 32 bytes. 2022-02-21T11:02:31+00:00 Kenny Levinsen kl@kl.wtf 2022-02-21T10:46:48+00:00 urn:sha1:10658dc5439db429af0088295a051c53925a4416 This should not need to be configured, so remove the argument. If downstream prefers a different folder, the location can be made compile-time configurable like for seatd itself. 2022-02-21T11:02:31+00:00 Kenny Levinsen kl@kl.wtf 2022-02-21T10:44:27+00:00 urn:sha1:32d06482d3aeaac166d76912fcba53fa8dfb2fcf seatd cleans up after itself and takes care of stale sockets when applicable, so seatd-launch should not replicate this functionality. 2021-09-15T22:55:43+00:00 Kenny Levinsen kl@kl.wtf 2021-09-15T22:10:56+00:00 urn:sha1:ebf512c2bf74b1286d2f243c2f78daa64114d81d The parent environment might contain nasty things. Create a new environment for the seatd process containing only the environment variables we care about. For now, that's only SEATD_LOGLEVEL. 2021-09-15T22:46:49+00:00 Kenny Levinsen kl@kl.wtf 2021-09-15T21:34:02+00:00 urn:sha1:907b75de1ae5ec415a99889faecaf05b36bea31e We previously used execlp to execute seatd, which had the effect of searching PATH for the executable. This allowed the caller to control what executable was run, which is bad if SUID has been set. Instead, expose the absolute install path for seatd from meason as a define, and use that in a call to execv. 2021-09-13T11:40:00+00:00 Simon Ser contact@emersion.fr 2021-09-13T09:59:46+00:00 urn:sha1:4e3b7b3bb605daf7337db0c922904c251c58289a Makes it easier to find out that something went wrong.