aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2012-04-26Disable some questionable linesChristian Ruppert
Caused by bug 412589 I was looking at the do_mark_service() function and quickly found that the segfault is caused by a strlen() call against a NULL pointer. I also noticed it's using "/exclusive/%s.%s" so svcname.pid, all other functions are just using the svcname.. So it seems that svcname.pid was/is never used and thus not necessary at all. In relation to the above, the if statement in the do_mark_service() function ("if (ok && svcname && strcmp(svcname, service) == 0) {") needs to be fixed/improved as svcname and service are almost always equal, see my comment in the function for further details. Signed-off-by: Christian Ruppert <idl0r@gentoo.org> Reported-by: Patrick McLean <chutzpah@gentoo.org> X-Gentoo-Bug: 412589 X-Gentoo-Bug-URL: https://bugs.gentoo.org/412589
2012-04-24Remove duplicate getenv("RC_SVCNAME") callChristian Ruppert
2012-03-26librc: Do not output error messages from within the library.William Hubbs
This fixes a compile issue. Also, it is cleaner to have the client output error messages as opposed to having the library do this. Reported-by: Ewoud Kohl van Wijngaarden <gentoo@kohlvanwijngaarden.nl> X-Gentoo-Bug: 409743 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=409743
2012-02-25librc: make rc_proc_getent available for all operating systemsWilliam Hubbs
This looks up an option on the kernel command line. For now, itworks on linux and returns NULL on the bsds, but we are definitely open to patches for that side.
2012-02-25Fix rc_proc_getent() undeclared on BSDChristian Ruppert
X-Gentoo-Bug: 405713 X-Gentoo-Bug-URL: https://bugs.gentoo.org/405713 Reported-by: Dmitri Bogomolov <4glitch@gmail.com>
2012-02-23Skip pam if running as rootWilliam Hubbs
Reported-by: Piotr Karbowski <piotr.karbowski@gmail.com> X-Gentoo-Bug: 386623 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=386623
2012-02-21Remove prefix supportWilliam Hubbs
I spoke with the prefix team sometime back and was told that they do not have an interest in using OpenRC on prefix systems.
2012-02-20rc: remove calls to rc_sys_v2 and rc_sys_v1William Hubbs
These separate calls are no longer needed since we do not warn about falling back to automatic detection.
2012-02-20remove the warning about falling back to autodetectionJory A. Pratt
2012-02-12Fix some more warningsChristian Ruppert
2012-02-12Use size_t instead of intChristian Ruppert
2012-02-11Remove unused/useless function single_user()Christian Ruppert
2012-01-31fstabinfo: add --remount optionWilliam Hubbs
This adds a --remount/-R option to fstabinfo. This new option works like --mount, but it adds the necessary options to remount a file system that is already mounted. Reported-by: Piotr Karbowski <piotr.karbowski@gmail.com> X-Gentoo-Bug: 401573 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=401573
2012-01-30Complain about loading /etc/conf.d/rcWilliam Hubbs
Openrc was quietly loading this file if it existed and this was causing some issues, so now openrc loads the file and complains about it. Hopefully the warning message will convince everyone to remove this file and migrate the settings to @SYSCONFDIR@/rc.conf where they belong.
2012-01-28Do not unlink the temp. log during shutdownChristian Ruppert
Also ignore errors in case of EROFS (Read-Only file systems) Reported-by: Maxim Kammerer X-Gentoo-Bug: 401115 X-Gentoo-Bug-URL: https://bugs.gentoo.org/401115
2012-01-28Do not loop flock()Christian Ruppert
There's no need to loop until flock was successfully as flock() would simply block till a previous lock has been released. There's more to do to fix it properly, see my comments in the patch. Reported-by: James Le Cuirot <chewi@aura-online.co.uk> X-Gentoo-Bug: 360013 X-Gentoo-Bug-URL: https://bugs.gentoo.org/360013
2012-01-26Add -W/--writable function to checkpathChristian Ruppert
Checkpath -W will use access(3p) to determine whether or not a path is writable. This is more accurate than test(1p) because it also takes into account whether or not the filesystem is mounted read-only. Modified by William Hubbs to add the man page update.
2012-01-26WhitespaceChristian Ruppert
2012-01-26Add is_writable() function to check whether a path is writable or notChristian Ruppert
2012-01-24Disable parallel startup in interactive modeChristian Ruppert
2012-01-24Override rc.conf options onlyChristian Ruppert
2012-01-23Per the systemd tmpfiles implementation, we need to watch out for umask ↵Robin H. Johnson
during initial creation of files as well as potentially changing permissions later. Also do not abort if the items exist already, per truncate rules in tmpfiles. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
2012-01-23Ensure that when -F is passed, existing files are truncated properly.Robin H. Johnson
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
2012-01-23Respin features.h usage so that we correctly test for features before we use ↵Robin H. Johnson
them. Some BSD libc implementations may have one or the other flag, but not both. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
2012-01-23Revert "Drop include for features.h"Robin H. Johnson
This reverts commit 30a565f80d6056ccabadf77e347cf17067133f7e.
2012-01-22Drop include for features.hWilliam Hubbs
The following information is taken from the feature_test_macros man page: <features.h> is a Linux/glibc-specific header file. Other systems have an analogous file, but typically with a different name. This header file is automatically included by other header files as required: it is not necessary to explicitly include it in order to employ feature test macros. Reported-by: Tibor Vago <tibor.vago@gmail.com> X-Gentoo-Bug: 399635 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=399635
2012-01-20small style fixWilliam Hubbs
2012-01-16style fixesWilliam Hubbs
2012-01-15Add "ifstopped" command to runscriptChristian Ruppert
Signed-off-by: Christian Ruppert <idl0r@gentoo.org>
2012-01-15Allow overriding of rc.conf options via kernel cmdlineChristian Ruppert
This adds a new function that allows us to override some specific rc.conf options via the kernel cmdline aka /proc/cmdline. This makes esp. sense in cases where a rc_parallel enabled system has boot issues. Simply disable rc_parallel by appending rc_parallel=no to your kernel cmdline.
2012-01-15Rename proc_getent to rc_proc_getent and make it globalChristian Ruppert
2012-01-09rc/checkpath: tmpfiles.d backend creation codeRobin H. Johnson
This commit provides the checkpath applet with feature parity to systemd's tmpfiles.c create_item function. Very similarly to the systemd function, it does NOT do any of the cleanup work in this function. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
2011-12-31Do not exit immediately when a service has been stopped alreadyChristian Ruppert
The old behaviour was to exit(EXIT_SUCCESS) in case the service has been stopped already, even if further commands has been passed to the init script (like zap, start). So using for example /etc/init.d/foo stop zap start would abort immediately after "stop" if the service has been stopped already. Though there may be cases were we need it to proceed with the remaining commands, zap and start in this case. This patch fixes the behaviour to continue and proceed with the remaining commands whenever necessary. X-Gentoo-Bug: 371845 X-Gentoo-Bug-URL: https://bugs.gentoo.org/371845
2011-12-30Code style fixesChristian Ruppert
2011-12-30Compare stricter in proc_getentChristian Ruppert
The new proc_getent compares stricter so that e.g. "ro" doesn't match root=/dev/sdaN anymore. So it has to be either "ro" or "ro=".
2011-12-29Don't try to write the log during sysinitChristian Ruppert
During the sysinit and shutdown runlevels the logfile destination may be read-only. Skip the error messages in this case. X-Gentoo-Bug: 390645 X-Gentoo-Bug-URL: https://bugs.gentoo.org/390645
2011-12-29Use RC_LEVEL_SHUTDOWNChristian Ruppert
2011-12-29Remove useless rc_runlevel_get() callChristian Ruppert
The current runlevel will be passed to rc_logger_open() already.
2011-12-29Don't print error when the logfile isn't writeable during shutdownChristian Ruppert
The logfile or its basedir may be read-only during shutdown because the directory may be umounted or read-only remounted already. In this case we simply skip this error. This is related to a comment in bug 390645 but the initial bug is not fixed through this commit. X-Gentoo-Bug: 390645 X-Gentoo-Bug-URL: https://bugs.gentoo.org/390645
2011-12-11fix compile errorWilliam Hubbs
A variable used in the previous commit was actually removed in another commit; that is why I didn't catch it. Reported-by: Duncan < 1i5t5.duncan@cox.net> X-Gentoo-Bug: 394369 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=394369
2011-12-11Allow init scripts to be executed with a relative pathWilliam Hubbs
This was a regression that was caused by the fix for http://bugs.gentoo.org/show_bug.cgi?id=350910. I am reverting the commit that we said fixed that bug and re-opening it. Reported-By: Nathaniel <nathaniel@paust.us X-Gentoo-Bug: 392457 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=392457
2011-11-19rc: usage: do not output non-printable short options in usageMike Frysinger
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-11-19rc: usage: optimize help string alignment output a littleMike Frysinger
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-11-19rc: fix style around case_RC_COMMON_GETOPTMike Frysinger
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-11-19make shell math operations style more succulentMike Frysinger
Convert the style: var=$((${var} + 1)) to: : $(( var += 1 )) The latter is easier to read imo. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-11-17Fix compile warningWilliam Hubbs
2011-11-16add support for extra_stopped_commandsWilliam Hubbs
2011-11-15mountinfo: Do not error out if realpath failsMike Frysinger
Reported-By: Dennis Schridde <devurandom@gmx.net> X-Gentoo-Bug: 383333 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=383333
2011-11-09ssd: fix building when SYS_ioprio_set is missingMike Frysinger
Older glibc's might not provide this. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2011-11-07add auto detection for lxcWilliam Hubbs
Reported-by: Francesco Riosa <francesco+gentoo_bugzilla@pnpitalia.it> X-Gentoo-Bug: 384151 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=384151
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-01 10:29:04 +0000